From patchwork Mon Oct 22 04:42:59 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: TTY: hvcs: fix missing unlock on error in hvcs_initialize() Date: Sun, 21 Oct 2012 18:42:59 -0000 From: Wei Yongjun X-Patchwork-Id: 193074 Message-Id: To: gregkh@linuxfoundation.org Cc: yongjun_wei@trendmicro.com.cn, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org From: Wei Yongjun Add the missing unlock on the error handling path in function hvcs_initialize(). Signed-off-by: Wei Yongjun --- drivers/tty/hvc/hvcs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/tty/hvc/hvcs.c b/drivers/tty/hvc/hvcs.c index cab5c7a..744c3b8 100644 --- a/drivers/tty/hvc/hvcs.c +++ b/drivers/tty/hvc/hvcs.c @@ -1496,8 +1496,10 @@ static int __devinit hvcs_initialize(void) num_ttys_to_alloc = hvcs_parm_num_devs; hvcs_tty_driver = alloc_tty_driver(num_ttys_to_alloc); - if (!hvcs_tty_driver) + if (!hvcs_tty_driver) { + mutex_unlock(&hvcs_init_mutex); return -ENOMEM; + } if (hvcs_alloc_index_list(num_ttys_to_alloc)) { rc = -ENOMEM;