Patchwork [09/18] Add native:libglib in pkgconfig oeclass

login
register
mail settings
Submitter Yann Diorcet
Date Oct. 21, 2012, 3:27 p.m.
Message ID <1350833261-8401-9-git-send-email-diorcet.yann@gmail.com>
Download mbox | patch
Permalink /patch/193013/
State RFC
Delegated to: Esben Haabendal
Headers show

Comments

Yann Diorcet - Oct. 21, 2012, 3:27 p.m.
From: Yann Diorcet <yann.diorcet@belledonne-communications.com>

pkg-config depends on libglib but PKGCONFIG_DEPENDS not resolves recursivley the depend
---
 classes/pkgconfig.oeclass |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Esben Haabendal - Dec. 14, 2012, 8 p.m.
Yann Diorcet <diorcet.yann@gmail.com> writes:

> From: Yann Diorcet <yann.diorcet@belledonne-communications.com>
>
> pkg-config depends on libglib but PKGCONFIG_DEPENDS not resolves recursivley the depend
> ---
>  classes/pkgconfig.oeclass |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/classes/pkgconfig.oeclass b/classes/pkgconfig.oeclass
> index a102248..7c7bf8d 100644
> --- a/classes/pkgconfig.oeclass
> +++ b/classes/pkgconfig.oeclass
> @@ -1,4 +1,4 @@
> -PKGCONFIG_DEPENDS = "native:pkg-config"
> +PKGCONFIG_DEPENDS = "native:pkg-config native:libglib"
>  CLASS_DEPENDS += "${PKGCONFIG_DEPENDS}"
>  
>  export PKG_CONFIG_LIBDIR	= "${HOST_SYSROOT}${libdir}/pkgconfig"

Wouldn't it be better (more correct) to add

DEPENDS_${PN} += "libglib"

in pkg-config recipe?

/Esben

Patch

diff --git a/classes/pkgconfig.oeclass b/classes/pkgconfig.oeclass
index a102248..7c7bf8d 100644
--- a/classes/pkgconfig.oeclass
+++ b/classes/pkgconfig.oeclass
@@ -1,4 +1,4 @@ 
-PKGCONFIG_DEPENDS = "native:pkg-config"
+PKGCONFIG_DEPENDS = "native:pkg-config native:libglib"
 CLASS_DEPENDS += "${PKGCONFIG_DEPENDS}"
 
 export PKG_CONFIG_LIBDIR	= "${HOST_SYSROOT}${libdir}/pkgconfig"