Patchwork [04/10] busybox: busybox-update-config should depend on busybox-configure

login
register
mail settings
Submitter Arnout Vandecappelle
Date Oct. 20, 2012, 11:45 p.m.
Message ID <1350776731-8467-5-git-send-email-arnout@mind.be>
Download mbox | patch
Permalink /patch/192968/
State Accepted
Commit f026d3642d9ea3bcbc85f2f1ab302a3e35eaa0de
Headers show

Comments

Arnout Vandecappelle - Oct. 20, 2012, 11:45 p.m.
From: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>

Before the config file can be copied, it has to exist.  The
other xxx-update-config targets to this as well.

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
 package/busybox/busybox.mk |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Samuel Martin - Oct. 21, 2012, 3:07 p.m.
Arnout, all,

2012/10/21 Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>:
> From: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
>
> Before the config file can be copied, it has to exist.  The
> other xxx-update-config targets to this as well.
>
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
>  package/busybox/busybox.mk |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/busybox/busybox.mk b/package/busybox/busybox.mk
> index 33f8633..e95364c 100644
> --- a/package/busybox/busybox.mk
> +++ b/package/busybox/busybox.mk
> @@ -215,5 +215,5 @@ busybox-menuconfig busybox-xconfig busybox-gconfig: busybox-patch
>         rm -f $(BUSYBOX_DIR)/.stamp_built
>         rm -f $(BUSYBOX_DIR)/.stamp_target_installed
>
> -busybox-update-config:
> +busybox-update-config: busybox-configure
>         cp -f $(BUSYBOX_BUILD_CONFIG) $(BUSYBOX_CONFIG_FILE)
How about saving the busybox-defconfig instead?


Regards,
Arnout Vandecappelle - Oct. 23, 2012, 1:15 p.m.
On 21/10/12 17:07, Samuel Martin wrote:
> Arnout, all,
>
> 2012/10/21 Arnout Vandecappelle (Essensium/Mind)<arnout@mind.be>:
>> >  From: "Arnout Vandecappelle (Essensium/Mind)"<arnout@mind.be>
>> >
>> >  Before the config file can be copied, it has to exist.  The
>> >  other xxx-update-config targets to this as well.
>> >
>> >  Signed-off-by: Arnout Vandecappelle (Essensium/Mind)<arnout@mind.be>
>> >  ---
>> >    package/busybox/busybox.mk |    2 +-
>> >    1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> >  diff --git a/package/busybox/busybox.mk b/package/busybox/busybox.mk
>> >  index 33f8633..e95364c 100644
>> >  --- a/package/busybox/busybox.mk
>> >  +++ b/package/busybox/busybox.mk
>> >  @@ -215,5 +215,5 @@ busybox-menuconfig busybox-xconfig busybox-gconfig: busybox-patch
>> >           rm -f $(BUSYBOX_DIR)/.stamp_built
>> >           rm -f $(BUSYBOX_DIR)/.stamp_target_installed
>> >
>> >  -busybox-update-config:
>> >  +busybox-update-config: busybox-configure
>> >           cp -f $(BUSYBOX_BUILD_CONFIG) $(BUSYBOX_CONFIG_FILE)
> How about saving the busybox-defconfig instead?

  Is there a busybox version that has a savedefconfig target?

  Anyway, that would again be a separate patch.

  Regards,
  Arnout

Patch

diff --git a/package/busybox/busybox.mk b/package/busybox/busybox.mk
index 33f8633..e95364c 100644
--- a/package/busybox/busybox.mk
+++ b/package/busybox/busybox.mk
@@ -215,5 +215,5 @@  busybox-menuconfig busybox-xconfig busybox-gconfig: busybox-patch
 	rm -f $(BUSYBOX_DIR)/.stamp_built
 	rm -f $(BUSYBOX_DIR)/.stamp_target_installed
 
-busybox-update-config:
+busybox-update-config: busybox-configure
 	cp -f $(BUSYBOX_BUILD_CONFIG) $(BUSYBOX_CONFIG_FILE)