Patchwork configure: Remove stray debug output

login
register
mail settings
Submitter Peter Maydell
Date Oct. 20, 2012, 7:37 p.m.
Message ID <1350761824-28185-1-git-send-email-peter.maydell@linaro.org>
Download mbox | patch
Permalink /patch/192943/
State New
Headers show

Comments

Peter Maydell - Oct. 20, 2012, 7:37 p.m.
Rather than printing a message saying we're silently falling
back to gthread coroutines when running on MacOS, actually
do it silently.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
I guess this is a self-falsifying echo :-)

 configure | 2 --
 1 file changed, 2 deletions(-)
Stefan Hajnoczi - Oct. 29, 2012, 9:54 a.m.
On Sat, Oct 20, 2012 at 08:37:04PM +0100, Peter Maydell wrote:
> Rather than printing a message saying we're silently falling
> back to gthread coroutines when running on MacOS, actually
> do it silently.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> I guess this is a self-falsifying echo :-)
> 
>  configure | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/configure b/configure
> index 9f33c7d..e07baf3 100755
> --- a/configure
> +++ b/configure
> @@ -2900,8 +2900,6 @@ EOF
>      else
>  	coroutine_backend=gthread
>      fi
> -  else
> -    echo "Silently falling back into gthread backend under darwin"
>    fi

Is there a reason to remove the echo?

Stefan
Peter Maydell - Oct. 29, 2012, 10:01 a.m.
On 29 October 2012 09:54, Stefan Hajnoczi <stefanha@gmail.com> wrote:
> On Sat, Oct 20, 2012 at 08:37:04PM +0100, Peter Maydell wrote:
>> Rather than printing a message saying we're silently falling
>> back to gthread coroutines when running on MacOS, actually
>> do it silently.
>>
>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>> ---
>> I guess this is a self-falsifying echo :-)
>>
>>  configure | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/configure b/configure
>> index 9f33c7d..e07baf3 100755
>> --- a/configure
>> +++ b/configure
>> @@ -2900,8 +2900,6 @@ EOF
>>      else
>>       coroutine_backend=gthread
>>      fi
>> -  else
>> -    echo "Silently falling back into gthread backend under darwin"
>>    fi
>
> Is there a reason to remove the echo?

1. Nothing else in configure prints progress messages during the
   testing phase
2. The echo is by definition printing something that's false
3. We print the chosen coroutine backend at the end as part of
   the standard "what did configure do?" output block, so removing
   this echo loses no information

-- PMM
Stefan Hajnoczi - Nov. 16, 2012, 2:28 p.m.
On Sat, Oct 20, 2012 at 08:37:04PM +0100, Peter Maydell wrote:
> Rather than printing a message saying we're silently falling
> back to gthread coroutines when running on MacOS, actually
> do it silently.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> I guess this is a self-falsifying echo :-)
> 
>  configure | 2 --
>  1 file changed, 2 deletions(-)

Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches

Stefan

Patch

diff --git a/configure b/configure
index 9f33c7d..e07baf3 100755
--- a/configure
+++ b/configure
@@ -2900,8 +2900,6 @@  EOF
     else
 	coroutine_backend=gthread
     fi
-  else
-    echo "Silently falling back into gthread backend under darwin"
   fi
 elif test "$coroutine" = "gthread" ; then
   coroutine_backend=gthread