Patchwork [U-Boot] tegra20: initialize variable to avoid compiler warning

login
register
mail settings
Submitter Allen Martin
Date Oct. 20, 2012, 7:18 a.m.
Message ID <1350717484-19380-1-git-send-email-amartin@nvidia.com>
Download mbox | patch
Permalink /patch/192908/
State Accepted
Delegated to: Tom Warren
Headers show

Comments

Allen Martin - Oct. 20, 2012, 7:18 a.m.
Initialize this variable to avoid a compiler warning about possible
use of uninitialized variable with gcc 4.4.6.

Signed-off-by: Allen Martin <amartin@nvidia.com>
---
 arch/arm/cpu/tegra20-common/emc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Stephen Warren - Oct. 22, 2012, 5:07 p.m.
On 10/20/2012 01:18 AM, Allen Martin wrote:
> Initialize this variable to avoid a compiler warning about possible
> use of uninitialized variable with gcc 4.4.6.

Acked-by: Stephen Warren <swarren@nvidia.com>
Simon Glass - Oct. 26, 2012, 4:38 p.m.
Hi,

On Sat, Oct 20, 2012 at 12:18 AM, Allen Martin <amartin@nvidia.com> wrote:
> Initialize this variable to avoid a compiler warning about possible
> use of uninitialized variable with gcc 4.4.6.
>
> Signed-off-by: Allen Martin <amartin@nvidia.com>

Acked-by: Simon Glass <sjg@chromium.org>
Tested-by: Simon Glass <sjg@chromium.org>

I suppose the compiler is confused by the 'return node' bit. It might
be better to set '*emcp = NULL' at the top of decode_emc(), but this
is fine too.

> ---
>  arch/arm/cpu/tegra20-common/emc.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/cpu/tegra20-common/emc.c b/arch/arm/cpu/tegra20-common/emc.c
> index 97420d7..90edf00 100644
> --- a/arch/arm/cpu/tegra20-common/emc.c
> +++ b/arch/arm/cpu/tegra20-common/emc.c
> @@ -257,7 +257,7 @@ static int decode_emc(const void *blob, unsigned rate, struct emc_ctlr **emcp,
>  int tegra_set_emc(const void *blob, unsigned rate)
>  {
>         struct emc_ctlr *emc;
> -       const u32 *table;
> +       const u32 *table = NULL;
>         int err, i;
>
>         err = decode_emc(blob, rate, &emc, &table);
> --
> 1.7.10.4
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

Patch

diff --git a/arch/arm/cpu/tegra20-common/emc.c b/arch/arm/cpu/tegra20-common/emc.c
index 97420d7..90edf00 100644
--- a/arch/arm/cpu/tegra20-common/emc.c
+++ b/arch/arm/cpu/tegra20-common/emc.c
@@ -257,7 +257,7 @@  static int decode_emc(const void *blob, unsigned rate, struct emc_ctlr **emcp,
 int tegra_set_emc(const void *blob, unsigned rate)
 {
 	struct emc_ctlr *emc;
-	const u32 *table;
+	const u32 *table = NULL;
 	int err, i;
 
 	err = decode_emc(blob, rate, &emc, &table);