From patchwork Fri Oct 19 21:09:12 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chuck Lever X-Patchwork-Id: 192816 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from rcsinet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "rcsinet15.oracle.com", Issuer "VeriSign Class 3 International Server CA - G3" (not verified)) by ozlabs.org (Postfix) with ESMTPS id A65592C04D0 for ; Sat, 20 Oct 2012 08:09:21 +1100 (EST) Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by rcsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q9JL9Ic4002586 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 19 Oct 2012 21:09:19 GMT Received: from oss.oracle.com (oss-external.oracle.com [137.254.96.51]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q9JL9ISM001493 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 19 Oct 2012 21:09:18 GMT Received: from localhost ([127.0.0.1] helo=oss.oracle.com) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1TPJok-0007Jy-0n; Fri, 19 Oct 2012 14:09:18 -0700 Received: from ucsinet21.oracle.com ([156.151.31.93]) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1TPJoi-0007Jm-8i for fedfs-utils-devel@oss.oracle.com; Fri, 19 Oct 2012 14:09:16 -0700 Received: from rcsinet11.oracle.com (rcsinet11.oracle.com [148.87.113.123]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q9JL9F8J014598 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 19 Oct 2012 21:09:15 GMT Received: from mail-ie0-f171.google.com (mail-ie0-f171.google.com [209.85.223.171]) by rcsinet11.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q9JL8mUH008452 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=OK) for ; Fri, 19 Oct 2012 21:09:15 GMT Received: by mail-ie0-f171.google.com with SMTP id s9so1363018iec.2 for ; Fri, 19 Oct 2012 14:09:14 -0700 (PDT) Received: by 10.50.217.225 with SMTP id pb1mr2854568igc.46.1350680954901; Fri, 19 Oct 2012 14:09:14 -0700 (PDT) Received: from seurat.1015granger.net (adsl-99-26-161-222.dsl.sfldmi.sbcglobal.net. [99.26.161.222]) by mx.google.com with ESMTPS id gs6sm2319337igc.11.2012.10.19.14.09.13 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 19 Oct 2012 14:09:13 -0700 (PDT) From: Chuck Lever To: fedfs-utils-devel@oss.oracle.com Date: Fri, 19 Oct 2012 17:09:12 -0400 Message-ID: <20121019210912.53119.16757.stgit@seurat.1015granger.net> In-Reply-To: <20121019210357.53119.28925.stgit@seurat.1015granger.net> References: <20121019210357.53119.28925.stgit@seurat.1015granger.net> User-Agent: StGIT/0.14.3 MIME-Version: 1.0 X-Flow-Control-Info: class=Default reputation=ipRepBelow100 ip=209.85.223.171 ct-class=R5 ct-vol1=-97 ct-vol2=9 ct-vol3=8 ct-risk=49 ct-spam1=78 ct-spam2=8 ct-bulk=6 rcpts=1 size=1656 X-MM-CT-Classification: not spam X-MM-CT-RefID: str=0001.0A090207.5081C17B.0056,ss=1,re=0.000,fgs=0 Subject: [fedfs-utils] [PATCH 11/11] CheckInTests: Add a sparse requirement X-BeenThere: fedfs-utils-devel@oss.oracle.com X-Mailman-Version: 2.1.9 Precedence: list Reply-To: fedfs-utils Developers List-Id: fedfs-utils Developers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: fedfs-utils-devel-bounces@oss.oracle.com Errors-To: fedfs-utils-devel-bounces@oss.oracle.com X-Source-IP: acsinet21.oracle.com [141.146.126.237] Sparse provides some level of sanity checking for new commits, so make it a check-in test requirement. Signed-off-by: Chuck Lever --- doc/CheckInTests | 11 ++++++----- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/doc/CheckInTests b/doc/CheckInTests index d8f2c17..37bc2ef 100644 --- a/doc/CheckInTests +++ b/doc/CheckInTests @@ -87,24 +87,25 @@ This is basic stuff that's easy to run, and should be working for bisecting to be useful. 1. "autogen.sh" and "configure" must run without error - 2. "./configure --enable-silent-rules; make -s" must complete without - error, and without new compiler warnings + 2. "CC=cgcc ./configure --enable-silent-rules; make -s" must complete + without error, and without new compiler or sparse warnings 3. "make doxy" must complete with no errors or warnings 4. "make distcheck" must complete without error 5. "git status" must produce no output on a clean tree 6. "git log -p" shows no new white space damage 7. "git clean -d -f -x" does not break anything -Note that to preserve bisectability, the tree MUST build after each -commit. +To preserve bisectability, the tree MUST build after each commit. Try to maintain documentation coherency with code. Check code against man pages and the INSTALL and README documents. At some point, we'd like: + 1. Automated checking of coding style and white space - 2. fortify, sparse, or splint testing + 2. Automated fortify or splint testing during check-in 3. Automated unit tests + 4. Regular runs against coverity Per-release