Patchwork [08/11] mount.fedfs: Silence sparse warnings

login
register
mail settings
Submitter Chuck Lever
Date Oct. 19, 2012, 9:08 p.m.
Message ID <20121019210846.53119.17695.stgit@seurat.1015granger.net>
Download mbox | patch
Permalink /patch/192813/
State Accepted
Headers show

Comments

Chuck Lever - Oct. 19, 2012, 9:08 p.m.
Address these sparse warnings:

main.c:92:6: warning: symbol 'progname' was not declared. Should it be
static?
main.c:93:5: warning: symbol 'nomtab' was not declared. Should it be
static?
main.c:94:5: warning: symbol 'verbose' was not declared. Should it be
static?
main.c:95:7: warning: symbol 'readonly' was not declared. Should it be
static?
main.c:96:7: warning: symbol 'sloppy' was not declared. Should it be
static?
main.c:97:7: warning: symbol 'fake' was not declared. Should it be static?
main.c:109:22: warning: Using plain integer as NULL pointer
main.c:110:22: warning: Using plain integer as NULL pointer
main.c:111:25: warning: Using plain integer as NULL pointer
main.c:112:25: warning: Using plain integer as NULL pointer
main.c:113:27: warning: Using plain integer as NULL pointer
main.c:114:28: warning: Using plain integer as NULL pointer
main.c:115:20: warning: Using plain integer as NULL pointer
main.c:116:20: warning: Using plain integer as NULL pointer
main.c:117:24: warning: Using plain integer as NULL pointer
main.c:118:25: warning: Using plain integer as NULL pointer
main.c:119:25: warning: Using plain integer as NULL pointer
main.c:120:20: warning: Using plain integer as NULL pointer

Introduced by commit 0520ee72 "Initial commit" March 29, 2011.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---

 src/mount/main.c |   36 ++++++++++++++++++------------------
 1 files changed, 18 insertions(+), 18 deletions(-)

Patch

diff --git a/src/mount/main.c b/src/mount/main.c
index 1efde77..81fa238 100644
--- a/src/mount/main.c
+++ b/src/mount/main.c
@@ -89,12 +89,12 @@  enum {
 	EX_FAIL		= 32,
 };
 
-char *progname;
-int nomtab;
-int verbose;
-_Bool readonly;
-_Bool sloppy;
-_Bool fake;
+static char *progname;
+static int nomtab;
+static int verbose;
+static _Bool readonly;
+static _Bool sloppy;
+static _Bool fake;
 
 /**
  * Short form command line options
@@ -106,18 +106,18 @@  static const char fedfs_opts[] = "fhno:rsvVw";
  */
 static const struct option fedfs_longopts[] =
 {
-	{ "fake", 0, 0, 'f' },
-	{ "help", 0, 0, 'h' },
-	{ "no-mtab", 0, 0, 'n' },
-	{ "options", 1, 0, 'o' },
-	{ "read-only", 0, 0, 'r' },
-	{ "read-write", 0, 0, 'w' },
-	{ "ro", 0, 0, 'r' },
-	{ "rw", 0, 0, 'w' },
-	{ "sloppy", 0, 0, 's' },
-	{ "verbose", 0, 0, 'v' },
-	{ "version", 0, 0, 'V' },
-	{ NULL, 0, 0, 0 }
+	{ "fake", 0, NULL, 'f' },
+	{ "help", 0, NULL, 'h' },
+	{ "no-mtab", 0, NULL, 'n' },
+	{ "options", 1, NULL, 'o' },
+	{ "read-only", 0, NULL, 'r' },
+	{ "read-write", 0, NULL, 'w' },
+	{ "ro", 0, NULL, 'r' },
+	{ "rw", 0, NULL, 'w' },
+	{ "sloppy", 0, NULL, 's' },
+	{ "verbose", 0, NULL, 'v' },
+	{ "version", 0, NULL, 'V' },
+	{ NULL, 0, NULL, 0 }
 };
 
 /**