From patchwork Fri Oct 19 19:52:40 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xinliang David Li X-Patchwork-Id: 192797 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id A09032C008F for ; Sat, 20 Oct 2012 06:52:58 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1351281180; h=Comment: DomainKey-Signature:Received:Received:Received:Received: MIME-Version:Received:Received:In-Reply-To:References:Date: Message-ID:Subject:From:To:Cc:Content-Type:Mailing-List: Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:Sender:Delivered-To; bh=TisK50Fgr7E/EDK72Teap2/UV70=; b=LdfadkL4yh7UmEn4nEXWw1pdWPvDULL0Re7jHbmSq2PfoGsw1Uhi5GlZY7s/sG J/qi5E4cOzogZtWPkd352+nhqfw40Dnp+UOomfwDP6htcuPvpDYKIUPCZdJsntqI 0Ls3VWAX07ecNsS8nNB0/PWs/Br+glFK20SYYA4YVzubw= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:X-Google-DKIM-Signature:MIME-Version:Received:Received:In-Reply-To:References:Date:Message-ID:Subject:From:To:Cc:Content-Type:X-System-Of-Record:X-Gm-Message-State:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=CSXM9pofY2bIN0g/LuUZRV0uOspzhgs9yb/3EeFLyslsRXa2snvfEkzB1OpD9L cHsfUtbxZ3ZVVCOxPnaWSlw1iBh9GE0y5+TPI2XiqB7160IMSGf+VZakozCgH07q PZmBEg1gHypKSyip6AF8XzhpNWFUlgZcEL2q1B7swfrlk=; Received: (qmail 32006 invoked by alias); 19 Oct 2012 19:52:54 -0000 Received: (qmail 31998 invoked by uid 22791); 19 Oct 2012 19:52:53 -0000 X-SWARE-Spam-Status: No, hits=-6.0 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, KHOP_RCVD_TRUST, KHOP_THREADED, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_YE, RP_MATCHES_RCVD, TW_LV X-Spam-Check-By: sourceware.org Received: from mail-lb0-f175.google.com (HELO mail-lb0-f175.google.com) (209.85.217.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 19 Oct 2012 19:52:42 +0000 Received: by mail-lb0-f175.google.com with SMTP id y2so575432lbk.20 for ; Fri, 19 Oct 2012 12:52:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-system-of-record:x-gm-message-state; bh=7SzWMz1SKbJ5R2zkR9dhOTVj17kJCMGLl15/TFpSsFk=; b=n6uXPBWS4sCB+muXm6mP2YRhG/BAhhb973xr1C49xS03dcq8sALr+HX79UbbGpdEiV RJhlBBk/c5DAVKCb/qr8Mt44V5CPTlRUAudal4bAmiA8Ya2wjf2KQAJTeM1K3C6DwIEa glzGz24nGjyGByse1sW7YbYpC1v0qoZ7j9u1PhZDzXs8g0r98ci86PRNMV1zTCOC8R4P woZEhwqQfPn3md/RweTXpfffEjr/I2Tvd6dc2+8aR0ye2rUxfQ3kAkly6aPqGfNqAcqh 2VHZLwXuzcCcCvtFLjiyahIMafJWehGkMy+09gZbAI1ciTsOjAu3QXNoJGUeiHvcdeqo QC4w== MIME-Version: 1.0 Received: by 10.112.103.6 with SMTP id fs6mr995848lbb.93.1350676360509; Fri, 19 Oct 2012 12:52:40 -0700 (PDT) Received: by 10.152.23.1 with HTTP; Fri, 19 Oct 2012 12:52:40 -0700 (PDT) In-Reply-To: References: <20121016072730.GE584@tucnak.redhat.com> <20121018181636.GZ584@tucnak.redhat.com> Date: Fri, 19 Oct 2012 12:52:40 -0700 Message-ID: Subject: Re: [asan] migrate runtime from llvm From: Xinliang David Li To: Wei Mi Cc: Jakub Jelinek , Andrew Pinski , gcc-patches@gcc.gnu.org, Diego Novillo X-System-Of-Record: true X-Gm-Message-State: ALoCoQmzZ78ORC4TFj+yRc9sLW3FMwVDeCNJLhlBHeFJEl580rYdWyouEpjVOUHySQr3qt1Za23n9O+CZAnJdP6dfXC4aC+EtYzJuo96IGGYr5EZ/vMKwELLpZ8BG9KCDW6TriIv+pHwt+eZDgezh8eHdv+dYH7CrxPLMTlmRyeKUl4bjNaxzwvQ9j3C0DxKAf5+gNsvLIQh X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org The library builds fine with the following diff. The file acinclude.m4 is cloned from libmudflap. David index 485d169..3e847f1 100644 On Fri, Oct 19, 2012 at 11:02 AM, Wei Mi wrote: > David, I put the m4 subdir under libasan because once I use the .m4 > files (libtool.m4 lt~obsolete.m4 ltoptions.m4 ltsugar.m4 > ltversion.m4) and ltmain.sh under $topsrcdir, the problem that a bad > libtool was generated under > $topbuilddir/x86_64-unknown-linux-gnu/libasan you met yesterday > appeared. That is why I had to generate the new libtool m4 files and > ltmain.sh using libtoolize. > > Thanks, > Wei. > > On Fri, Oct 19, 2012 at 10:16 AM, Xinliang David Li wrote: >> I tried it, and this version works for me. >> >> Your probably do not need to add the m4 subdir under libasan. The >> required m4 files are either in .. or ../config dir. See how >> libmudflap does it. >> >> Other than that, if there are no other comments, the change is good to >> check into the branch. Remaining bugs can always be found and fixed >> later. >> >> thanks, >> >> David >> >> >> >> On Thu, Oct 18, 2012 at 8:04 PM, Wei Mi wrote: >>> Hi, >>> >>> David cought a problem in the last patch when he tries to built >>> libasan. The problem was that an incomplete libtool under libasan >>> build directory was generated. The cause is that the old patch used an >>> old ltmain.sh to generate libtool. I fix it and attach a new patch. >>> And the new patch move -lpthread and -ldl to libasan LDFLAGS. >>> >>> Thanks, >>> Wei. --- a/libasan/aclocal.m4 +++ b/libasan/aclocal.m4 @@ -1037,8 +1037,8 @@ AC_SUBST([am__tar]) AC_SUBST([am__untar]) ]) # _AM_PROG_TAR -m4_include([m4/libtool.m4]) -m4_include([m4/ltoptions.m4]) -m4_include([m4/ltsugar.m4]) -m4_include([m4/ltversion.m4]) -m4_include([m4/lt~obsolete.m4]) +m4_include([../config/ltoptions.m4]) +m4_include([../config/ltsugar.m4]) +m4_include([../config/ltversion.m4]) +#m4_include([../config/lt~obsolete.m4]) +m4_include([acinclude.m4])