Patchwork [asan] migrate runtime from llvm

login
register
mail settings
Submitter Xinliang David Li
Date Oct. 19, 2012, 7:52 p.m.
Message ID <CAAkRFZLzaTHTuP_vzbfDuY54Pq09JoPr_hSE-NEMJ51rdN-4Pw@mail.gmail.com>
Download mbox | patch
Permalink /patch/192797/
State New
Headers show

Comments

Xinliang David Li - Oct. 19, 2012, 7:52 p.m.
The library builds fine with the following diff. The file acinclude.m4
is cloned from libmudflap.

David

index 485d169..3e847f1 100644


On Fri, Oct 19, 2012 at 11:02 AM, Wei Mi <wmi@google.com> wrote:
> David, I put the m4 subdir under libasan because once I use the .m4
> files (libtool.m4  lt~obsolete.m4  ltoptions.m4  ltsugar.m4
> ltversion.m4) and ltmain.sh under $topsrcdir, the problem that a bad
> libtool was generated under
> $topbuilddir/x86_64-unknown-linux-gnu/libasan you met yesterday
> appeared.  That is why I had to generate the new libtool m4 files and
> ltmain.sh using libtoolize.
>
> Thanks,
> Wei.
>
> On Fri, Oct 19, 2012 at 10:16 AM, Xinliang David Li <davidxl@google.com> wrote:
>> I tried it, and this version works for me.
>>
>> Your probably do not need to add the m4 subdir under libasan.  The
>> required m4 files are either in .. or ../config dir. See how
>> libmudflap does it.
>>
>> Other than that, if there are no other comments, the change is good to
>> check into the branch. Remaining bugs can always be found and fixed
>> later.
>>
>> thanks,
>>
>> David
>>
>>
>>
>> On Thu, Oct 18, 2012 at 8:04 PM, Wei Mi <wmi@google.com> wrote:
>>> Hi,
>>>
>>> David cought a problem in the last patch when he tries to built
>>> libasan. The problem was that an incomplete libtool under libasan
>>> build directory was generated. The cause is that the old patch used an
>>> old ltmain.sh to generate libtool. I fix it and attach a new patch.
>>> And the new patch move -lpthread and -ldl to libasan LDFLAGS.
>>>
>>> Thanks,
>>> Wei.
Diego Novillo - Oct. 19, 2012, 7:53 p.m.
On Fri, Oct 19, 2012 at 3:52 PM, Xinliang David Li <davidxl@google.com> wrote:
> The library builds fine with the following diff. The file acinclude.m4
> is cloned from libmudflap.

This is OK with the corresponding ChangeLog entry (in ChangeLog.asan).


Diego.

Patch

--- a/libasan/aclocal.m4
+++ b/libasan/aclocal.m4
@@ -1037,8 +1037,8 @@  AC_SUBST([am__tar])
 AC_SUBST([am__untar])
 ]) # _AM_PROG_TAR

-m4_include([m4/libtool.m4])
-m4_include([m4/ltoptions.m4])
-m4_include([m4/ltsugar.m4])
-m4_include([m4/ltversion.m4])
-m4_include([m4/lt~obsolete.m4])
+m4_include([../config/ltoptions.m4])
+m4_include([../config/ltsugar.m4])
+m4_include([../config/ltversion.m4])
+#m4_include([../config/lt~obsolete.m4])
+m4_include([acinclude.m4])