Patchwork [Quantal,SRU] Revert "UBUNTU: [Config] Disable vt6656"

login
register
mail settings
Submitter Tim Gardner
Date Oct. 19, 2012, 6:22 p.m.
Message ID <1350670963-26480-1-git-send-email-tim.gardner@canonical.com>
Download mbox | patch
Permalink /patch/192786/
State New
Headers show

Comments

Tim Gardner - Oct. 19, 2012, 6:22 p.m.
This reverts commit 05276ce80836e944e77fff141ce3fb717663ddc6.

BugLink: http://bugs.launchpad.net/bugs/162671

Seems this was carried over from Oneiric->Precise

Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
---
 drivers/staging/Makefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Herton Ronaldo Krzesinski - Oct. 19, 2012, 6:28 p.m.

Brad Figg - Oct. 19, 2012, 11:30 p.m.
On 10/19/2012 11:22 AM, Tim Gardner wrote:
> This reverts commit 05276ce80836e944e77fff141ce3fb717663ddc6.
>
> BugLink: http://bugs.launchpad.net/bugs/162671
>
> Seems this was carried over from Oneiric->Precise
>
> Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
> ---
>   drivers/staging/Makefile |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/Makefile b/drivers/staging/Makefile
> index 3b32dd9..a987b3a 100644
> --- a/drivers/staging/Makefile
> +++ b/drivers/staging/Makefile
> @@ -27,7 +27,7 @@ obj-$(CONFIG_LINE6_USB)		+= line6/
>   obj-$(CONFIG_USB_SERIAL_QUATECH2)	+= serqt_usb2/
>   obj-$(CONFIG_OCTEON_ETHERNET)	+= octeon/
>   obj-$(CONFIG_VT6655)		+= vt6655/
> -#obj-$(CONFIG_VT6656)		+= vt6656/
> +obj-$(CONFIG_VT6656)		+= vt6656/
>   obj-$(CONFIG_VME_BUS)		+= vme/
>   obj-$(CONFIG_IPACK_BUS)		+= ipack/
>   obj-$(CONFIG_DX_SEP)            += sep/
>
Tim Gardner - Oct. 23, 2012, 8:42 p.m.
On 10/19/2012 12:22 PM, Tim Gardner wrote:
> This reverts commit 05276ce80836e944e77fff141ce3fb717663ddc6.
> 
> BugLink: http://bugs.launchpad.net/bugs/162671
> 
> Seems this was carried over from Oneiric->Precise
> 
> Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
> ---
>  drivers/staging/Makefile |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/Makefile b/drivers/staging/Makefile
> index 3b32dd9..a987b3a 100644
> --- a/drivers/staging/Makefile
> +++ b/drivers/staging/Makefile
> @@ -27,7 +27,7 @@ obj-$(CONFIG_LINE6_USB)		+= line6/
>  obj-$(CONFIG_USB_SERIAL_QUATECH2)	+= serqt_usb2/
>  obj-$(CONFIG_OCTEON_ETHERNET)	+= octeon/
>  obj-$(CONFIG_VT6655)		+= vt6655/
> -#obj-$(CONFIG_VT6656)		+= vt6656/
> +obj-$(CONFIG_VT6656)		+= vt6656/
>  obj-$(CONFIG_VME_BUS)		+= vme/
>  obj-$(CONFIG_IPACK_BUS)		+= ipack/
>  obj-$(CONFIG_DX_SEP)            += sep/
> 

I'm going retract this patch until this staging driver is sufficiently
stable that it can run a 64bit instance.

See
https://bugs.launchpad.net/ubuntu/+source/linux-source-2.6.22/+bug/162671/comments/81

rtg
Herton Ronaldo Krzesinski - Nov. 5, 2012, 11:52 p.m.
On Tue, Oct 23, 2012 at 02:42:21PM -0600, Tim Gardner wrote:
> On 10/19/2012 12:22 PM, Tim Gardner wrote:
> > This reverts commit 05276ce80836e944e77fff141ce3fb717663ddc6.
> > 
> > BugLink: http://bugs.launchpad.net/bugs/162671
> > 
> > Seems this was carried over from Oneiric->Precise
> > 
> > Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
> > ---
> >  drivers/staging/Makefile |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/Makefile b/drivers/staging/Makefile
> > index 3b32dd9..a987b3a 100644
> > --- a/drivers/staging/Makefile
> > +++ b/drivers/staging/Makefile
> > @@ -27,7 +27,7 @@ obj-$(CONFIG_LINE6_USB)		+= line6/
> >  obj-$(CONFIG_USB_SERIAL_QUATECH2)	+= serqt_usb2/
> >  obj-$(CONFIG_OCTEON_ETHERNET)	+= octeon/
> >  obj-$(CONFIG_VT6655)		+= vt6655/
> > -#obj-$(CONFIG_VT6656)		+= vt6656/
> > +obj-$(CONFIG_VT6656)		+= vt6656/
> >  obj-$(CONFIG_VME_BUS)		+= vme/
> >  obj-$(CONFIG_IPACK_BUS)		+= ipack/
> >  obj-$(CONFIG_DX_SEP)            += sep/
> > 
> 
> I'm going retract this patch until this staging driver is sufficiently
> stable that it can run a 64bit instance.
> 
> See
> https://bugs.launchpad.net/ubuntu/+source/linux-source-2.6.22/+bug/162671/comments/81

Precise have it still applied on master-next. Should we revert it, or
just restrict CONFIG_VT6656 only to i386?

> 
> rtg
> -- 
> Tim Gardner tim.gardner@canonical.com
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>
Tim Gardner - Nov. 6, 2012, 1:15 p.m.
On 11/05/2012 04:52 PM, Herton Ronaldo Krzesinski wrote:
> On Tue, Oct 23, 2012 at 02:42:21PM -0600, Tim Gardner wrote:
>> On 10/19/2012 12:22 PM, Tim Gardner wrote:
>>> This reverts commit 05276ce80836e944e77fff141ce3fb717663ddc6.
>>>
>>> BugLink: http://bugs.launchpad.net/bugs/162671
>>>
>>> Seems this was carried over from Oneiric->Precise
>>>
>>> Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
>>> ---
>>>   drivers/staging/Makefile |    2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/staging/Makefile b/drivers/staging/Makefile
>>> index 3b32dd9..a987b3a 100644
>>> --- a/drivers/staging/Makefile
>>> +++ b/drivers/staging/Makefile
>>> @@ -27,7 +27,7 @@ obj-$(CONFIG_LINE6_USB)		+= line6/
>>>   obj-$(CONFIG_USB_SERIAL_QUATECH2)	+= serqt_usb2/
>>>   obj-$(CONFIG_OCTEON_ETHERNET)	+= octeon/
>>>   obj-$(CONFIG_VT6655)		+= vt6655/
>>> -#obj-$(CONFIG_VT6656)		+= vt6656/
>>> +obj-$(CONFIG_VT6656)		+= vt6656/
>>>   obj-$(CONFIG_VME_BUS)		+= vme/
>>>   obj-$(CONFIG_IPACK_BUS)		+= ipack/
>>>   obj-$(CONFIG_DX_SEP)            += sep/
>>>
>>
>> I'm going retract this patch until this staging driver is sufficiently
>> stable that it can run a 64bit instance.
>>
>> See
>> https://bugs.launchpad.net/ubuntu/+source/linux-source-2.6.22/+bug/162671/comments/81
>
> Precise have it still applied on master-next. Should we revert it, or
> just restrict CONFIG_VT6656 only to i386?
>
>>
>> rtg
>> --

I've dropped it for now. There have been some commits since 3.6 so 
perhaps we can try it out for raring.

rtg

Patch

diff --git a/drivers/staging/Makefile b/drivers/staging/Makefile
index 3b32dd9..a987b3a 100644
--- a/drivers/staging/Makefile
+++ b/drivers/staging/Makefile
@@ -27,7 +27,7 @@  obj-$(CONFIG_LINE6_USB)		+= line6/
 obj-$(CONFIG_USB_SERIAL_QUATECH2)	+= serqt_usb2/
 obj-$(CONFIG_OCTEON_ETHERNET)	+= octeon/
 obj-$(CONFIG_VT6655)		+= vt6655/
-#obj-$(CONFIG_VT6656)		+= vt6656/
+obj-$(CONFIG_VT6656)		+= vt6656/
 obj-$(CONFIG_VME_BUS)		+= vme/
 obj-$(CONFIG_IPACK_BUS)		+= ipack/
 obj-$(CONFIG_DX_SEP)            += sep/