Patchwork pull request: batman-adv 2012-10-18

login
register
mail settings
Submitter Antonio Quartulli
Date Oct. 18, 2012, 7:24 p.m.
Message ID <1350588295-22587-1-git-send-email-ordex@autistici.org>
Download mbox
Permalink /patch/192424/
State Accepted
Delegated to: David Miller
Headers show

Pull-request

git://git.open-mesh.org/linux-merge.git tags/batman-adv-fix-for-davem

Comments

Antonio Quartulli - Oct. 18, 2012, 7:24 p.m.
Hello David,

here are two fixes intended for net. The first one fixes the CRC computation
used to check for broadcast packet duplicates. The wrong result lead to many
(more than 80%) broadcast packets being dropped and so making the network very
slow and mostly unusable. Think about all the ARP or DHCP requests not going
through.

The second patch fixes a potential race condition, still in the same duplicated
broadcast check procedure, which can lead to wrong outcomes under certain
circumstances.

I would also like to enqueue patch 1/2 for sending to stable-{3.5/3.6}.

Thanks a lot,
	Antonio




The following changes since commit 43c422eda99b894f18d1cca17bcd2401efaf7bd0:

  apparmor: fix apparmor OOPS in audit_log_untrustedstring+0x1c/0x40 (2012-10-17 16:29:46 -0700)

are available in the git repository at:

  git://git.open-mesh.org/linux-merge.git tags/batman-adv-fix-for-davem

for you to fetch changes up to 7dac7b76b8db87fc79857a53a09730fb2148579b:

  batman-adv: Fix potential broadcast BLA-duplicate-check race condition (2012-10-18 18:17:31 +0200)

----------------------------------------------------------------
Included fixes:
- Fix broadcast packet CRC calculation which can lead to ~80% broadcast packet
  loss
- Fix a race condition in duplicate broadcast packet check

----------------------------------------------------------------
Linus L├╝ssing (2):
      batman-adv: Fix broadcast packet CRC calculation
      batman-adv: Fix potential broadcast BLA-duplicate-check race condition

 net/batman-adv/bridge_loop_avoidance.c | 27 ++++++++++++++++++---------
 net/batman-adv/routing.c               |  8 +++++++-
 net/batman-adv/types.h                 |  2 ++
 3 files changed, 27 insertions(+), 10 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Oct. 18, 2012, 7:37 p.m.
From: Antonio Quartulli <ordex@autistici.org>
Date: Thu, 18 Oct 2012 21:24:53 +0200

> here are two fixes intended for net. The first one fixes the CRC computation
> used to check for broadcast packet duplicates. The wrong result lead to many
> (more than 80%) broadcast packets being dropped and so making the network very
> slow and mostly unusable. Think about all the ARP or DHCP requests not going
> through.
> 
> The second patch fixes a potential race condition, still in the same duplicated
> broadcast check procedure, which can lead to wrong outcomes under certain
> circumstances.

Pulled, thanks.

> I would also like to enqueue patch 1/2 for sending to stable-{3.5/3.6}.

Feel free to submit this to -stable once it hits Linus's tree.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html