Patchwork [v3,13/16] iostatus: forward block_job_iostatus_reset to block job

login
register
mail settings
Submitter Paolo Bonzini
Date Oct. 18, 2012, 2:49 p.m.
Message ID <1350571770-9836-14-git-send-email-pbonzini@redhat.com>
Download mbox | patch
Permalink /patch/192350/
State New
Headers show

Comments

Paolo Bonzini - Oct. 18, 2012, 2:49 p.m.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 block.c    | 3 +++
 blockjob.c | 3 +++
 blockjob.h | 6 +++++-
 3 file modificati, 11 inserzioni(+). 1 rimozione(-)

Patch

diff --git a/block.c b/block.c
index b167f61..3e76322 100644
--- a/block.c
+++ b/block.c
@@ -4319,6 +4319,9 @@  void bdrv_iostatus_reset(BlockDriverState *bs)
 {
     if (bdrv_iostatus_is_enabled(bs)) {
         bs->iostatus = BLOCK_DEVICE_IO_STATUS_OK;
+        if (bs->job) {
+            block_job_iostatus_reset(bs->job);
+        }
     }
 }
 
diff --git a/blockjob.c b/blockjob.c
index fbb7e1c..cda12c6 100644
--- a/blockjob.c
+++ b/blockjob.c
@@ -142,6 +142,9 @@  bool block_job_is_cancelled(BlockJob *job)
 void block_job_iostatus_reset(BlockJob *job)
 {
     job->iostatus = BLOCK_DEVICE_IO_STATUS_OK;
+    if (job->job_type->iostatus_reset) {
+        job->job_type->iostatus_reset(job);
+    }
 }
 
 struct BlockCancelData {
diff --git a/blockjob.h b/blockjob.h
index fb2392e..3792b73 100644
--- a/blockjob.h
+++ b/blockjob.h
@@ -42,6 +42,9 @@  typedef struct BlockJobType {
     /** Optional callback for job types that support setting a speed limit */
     void (*set_speed)(BlockJob *job, int64_t speed, Error **errp);
 
+    /** Optional callback for job types that need to forward I/O status reset */
+    void (*iostatus_reset)(BlockJob *job);
+
     /**
      * Optional callback for job types whose completion must be triggered
      * manually.
@@ -253,7 +256,8 @@  int block_job_cancel_sync(BlockJob *job);
  * block_job_iostatus_reset:
  * @job: The job whose I/O status should be reset.
  *
- * Reset I/O status on @job.
+ * Reset I/O status on @job and on BlockDriverState objects it uses,
+ * other than job->bs.
  */
 void block_job_iostatus_reset(BlockJob *job);