From patchwork Thu Oct 18 05:07:09 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shawn Guo X-Patchwork-Id: 192180 Return-Path: X-Original-To: incoming-imx@patchwork.ozlabs.org Delivered-To: patchwork-incoming-imx@bilbo.ozlabs.org Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:4978:20e::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id C253D2C00A3 for ; Thu, 18 Oct 2012 16:13:58 +1100 (EST) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TOiJz-0007PX-4B; Thu, 18 Oct 2012 05:07:03 +0000 Received: from mail-pa0-f49.google.com ([209.85.220.49]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TOiJt-0007PH-8d for linux-arm-kernel@lists.infradead.org; Thu, 18 Oct 2012 05:06:58 +0000 Received: by mail-pa0-f49.google.com with SMTP id bi5so8211785pad.36 for ; Wed, 17 Oct 2012 22:06:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent :x-gm-message-state; bh=lAxbJqCqaA0/G40+9rX2U6+ylqPJQ+pIpE34nOGt/M0=; b=VqAFSgAQBquRhEc6tEl35dqDR9rCLi8tuGj+/Mat/hO+hT/+VQhqb8FtJpmzyhWZjl 124RfgDkY794LvBWVwv9tlg9S6ndSJh8BWDNRepZUnTLxw3IPe3DpYSrtC1VPQetVpxi nhDt86qedS4trXb78oMvJPkD44OUdh/HIfm4VNxin0zCMgzmtQghJxMUEgTFeOTg1qWf yYx0ejTs5hb/bTpDZ1wruO6HgF8lSn0+FBhnrNo/6vEyft+ibP8bkOIlw0/BlcK/hsI8 5a8cBd3zOMwHyVHL9cVhLPkw0tCP9wy0DQAwuGgdTy8LwbeIxLzUtszJqbGzygyFMwGY uzKw== Received: by 10.68.138.170 with SMTP id qr10mr62475624pbb.53.1350536815260; Wed, 17 Oct 2012 22:06:55 -0700 (PDT) Received: from S2101-09.ap.freescale.net ([117.83.185.70]) by mx.google.com with ESMTPS id o10sm13741813paz.37.2012.10.17.22.06.51 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 17 Oct 2012 22:06:54 -0700 (PDT) Date: Thu, 18 Oct 2012 13:07:09 +0800 From: Shawn Guo To: Fabio Estevam Subject: Re: [PATCH v2] ARM: mach-imx: Let ARCH_MXC select HAVE_IMX_SRC Message-ID: <20121018050705.GC4378@S2101-09.ap.freescale.net> References: <1350484056-13437-1-git-send-email-festevam@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1350484056-13437-1-git-send-email-festevam@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Gm-Message-State: ALoCoQnKcIBBAY/+T5nVegCgleJw5q85f1PPW5qmqKRFYY2n08ODI8LueFW8mHBy1e+mDK2Qhf5q X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.220.49 listed in list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: linux-arm-kernel@lists.infradead.org, Fabio Estevam , arnd@arndb.de, kernel@pengutronix.de X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org List-Id: linux-imx-kernel.lists.patchwork.ozlabs.org On Wed, Oct 17, 2012 at 11:27:36AM -0300, Fabio Estevam wrote: > From: Fabio Estevam > > Since commit c5a0d497(ARM: imx: enable multi-platform build), > ARCH_MXC is selected by the following logic: > > config ARCH_MXC > def_bool y if ARCH_MULTI_V4_V5 || ARCH_MULTI_V6_V7 > > As vexpress_defconfig selects ARCH_MULTI_V6_V7, this leads to the following > build error when building for vexpress_defconfig: > > arch/arm/mach-imx/hotplug.c:49: undefined reference to `imx_enable_cpu' > arch/arm/mach-imx/platsmp.c:57: undefined reference to `imx_set_cpu_jump' > arch/arm/mach-imx/platsmp.c:58: undefined reference to `imx_enable_cpu' > > These missing functions are provided by arch/arm/mach-imx/src.c, which is > selected via HAVE_IMX_SRC. > > Currently only SOC_IMX6Q selects HAVE_IMX_SRC, so let ARCH_MXC select it and fix > the build error. > I think the right fix is to make ARCH_MXC user selectable, just like what vexpress does. I would fix the problem like below. Shawn diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig index e1f78f5..b732208 100644 --- a/arch/arm/mach-imx/Kconfig +++ b/arch/arm/mach-imx/Kconfig @@ -1,5 +1,5 @@ config ARCH_MXC - def_bool y if ARCH_MULTI_V4_V5 || ARCH_MULTI_V6_V7 + bool "Freescale i.MX family" if ARCH_MULTI_V7 select AUTO_ZRELADDR if !ZBOOT_ROM select ARM_PATCH_PHYS_VIRT select GENERIC_CLOCKEVENTS @@ -13,7 +13,7 @@ config ARCH_MXC help Support for Freescale MXC/iMX-based family of processors -menu "Freescale i.MX support" +menu "i.MX platform support" depends on ARCH_MXC config MXC_IRQ_PRIOR