Patchwork toolchain/crosstool-ng: vendor part of tuple should be 'buildroot'

login
register
mail settings
Submitter Thomas Petazzoni
Date Oct. 17, 2012, 9:46 p.m.
Message ID <1350510369-15364-1-git-send-email-thomas.petazzoni@free-electrons.com>
Download mbox | patch
Permalink /patch/192146/
State Accepted
Commit 965cab82af11943ed52ed70aafc9f72c79744664
Headers show

Comments

Thomas Petazzoni - Oct. 17, 2012, 9:46 p.m.
Since 11017f081fc5b034e680d89eaea729c19f450e01, the Crosstool-ng
backend generates toolchains that have a prefix inconsistent with what
Buildroot expects. Buildroot expects a "buildroot" vendor name, while
Crosstool-NG builds toolchain with the "unknown" vendor name.

This is causing build failure such as:

  http://autobuild.buildroot.org/results/15b2c0e50a81b86dd13af684c9254df2bc0df8de/build-end.log

Fix this by changing the vendor part of the tuple used by Crosstool-NG
to "buildroot".

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 toolchain/toolchain-crosstool-ng/crosstool-ng.mk |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Yann E. MORIN - Oct. 17, 2012, 9:49 p.m.
Thomas, All,

On Wednesday 17 October 2012 Thomas Petazzoni wrote:
> Since 11017f081fc5b034e680d89eaea729c19f450e01, the Crosstool-ng
> backend generates toolchains that have a prefix inconsistent with what
> Buildroot expects. Buildroot expects a "buildroot" vendor name, while
> Crosstool-NG builds toolchain with the "unknown" vendor name.
> 
> This is causing build failure such as:
> 
>   http://autobuild.buildroot.org/results/15b2c0e50a81b86dd13af684c9254df2bc0df8de/build-end.log
> 
> Fix this by changing the vendor part of the tuple used by Crosstool-NG
> to "buildroot".
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

> ---
>  toolchain/toolchain-crosstool-ng/crosstool-ng.mk |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/toolchain/toolchain-crosstool-ng/crosstool-ng.mk b/toolchain/toolchain-crosstool-ng/crosstool-ng.mk
> index d18f5d5..e46bb20 100644
> --- a/toolchain/toolchain-crosstool-ng/crosstool-ng.mk
> +++ b/toolchain/toolchain-crosstool-ng/crosstool-ng.mk
> @@ -201,7 +201,7 @@ CTNG_FIX_DOT_CONFIG_SED += s:^(|\# )(CT_ARCH_[BL]E).*:\# \2 is not set:;
>  CTNG_FIX_DOT_CONFIG_SED += s:^\# (CT_ARCH_$(CTNG_ENDIAN)) is not set:\1=y:;
>  CTNG_FIX_DOT_CONFIG_SED += s:^(|\# )(CT_ARCH_(32|64)).*:\# \2 is not set:;
>  CTNG_FIX_DOT_CONFIG_SED += s:^\# (CT_ARCH_$(CTNG_BIT)) is not set:\1=y:;
> -CTNG_FIX_DOT_CONFIG_SED += s:^(CT_TARGET_VENDOR)=.*:\1="unknown":;
> +CTNG_FIX_DOT_CONFIG_SED += s:^(CT_TARGET_VENDOR)=.*:\1="buildroot":;
>  CTNG_FIX_DOT_CONFIG_SED += s:^(CT_TARGET_ALIAS)=.*:\1="$(ARCH)-linux":;
>  CTNG_FIX_DOT_CONFIG_SED += s:^(CT_TOOLCHAIN_PKGVERSION)="(.*)":\1="buildroot $(BR2_VERSION_FULL)":;
>  ifneq ($(call qstrip,$(BR2_USE_MMU)),)
> -- 
> 1.7.9.5
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
> 
>
Arnout Vandecappelle - Oct. 17, 2012, 10:19 p.m.
On 17/10/12 23:49, Yann E. MORIN wrote:
> On Wednesday 17 October 2012 Thomas Petazzoni wrote:
>> >  Since 11017f081fc5b034e680d89eaea729c19f450e01, the Crosstool-ng
>> >  backend generates toolchains that have a prefix inconsistent with what
>> >  Buildroot expects. Buildroot expects a "buildroot" vendor name, while
>> >  Crosstool-NG builds toolchain with the "unknown" vendor name.
>> >
>> >  This is causing build failure such as:
>> >
>> >     http://autobuild.buildroot.org/results/15b2c0e50a81b86dd13af684c9254df2bc0df8de/build-end.log
>> >
>> >  Fix this by changing the vendor part of the tuple used by Crosstool-NG
>> >  to "buildroot".
>> >
>> >  Signed-off-by: Thomas Petazzoni<thomas.petazzoni@free-electrons.com>
> Acked-by: "Yann E. MORIN"<yann.morin.1998@free.fr>

Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

  I had the very same patch lined up but forgot to commit and mail it...

  Regards,
  Arnout
Peter Korsgaard - Oct. 18, 2012, 7:10 a.m.
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 Thomas> Since 11017f081fc5b034e680d89eaea729c19f450e01, the Crosstool-ng
 Thomas> backend generates toolchains that have a prefix inconsistent with what
 Thomas> Buildroot expects. Buildroot expects a "buildroot" vendor name, while
 Thomas> Crosstool-NG builds toolchain with the "unknown" vendor name.

 Thomas> This is causing build failure such as:

 Thomas>   http://autobuild.buildroot.org/results/15b2c0e50a81b86dd13af684c9254df2bc0df8de/build-end.log

 Thomas> Fix this by changing the vendor part of the tuple used by Crosstool-NG
 Thomas> to "buildroot".

Committed, thanks.

Patch

diff --git a/toolchain/toolchain-crosstool-ng/crosstool-ng.mk b/toolchain/toolchain-crosstool-ng/crosstool-ng.mk
index d18f5d5..e46bb20 100644
--- a/toolchain/toolchain-crosstool-ng/crosstool-ng.mk
+++ b/toolchain/toolchain-crosstool-ng/crosstool-ng.mk
@@ -201,7 +201,7 @@  CTNG_FIX_DOT_CONFIG_SED += s:^(|\# )(CT_ARCH_[BL]E).*:\# \2 is not set:;
 CTNG_FIX_DOT_CONFIG_SED += s:^\# (CT_ARCH_$(CTNG_ENDIAN)) is not set:\1=y:;
 CTNG_FIX_DOT_CONFIG_SED += s:^(|\# )(CT_ARCH_(32|64)).*:\# \2 is not set:;
 CTNG_FIX_DOT_CONFIG_SED += s:^\# (CT_ARCH_$(CTNG_BIT)) is not set:\1=y:;
-CTNG_FIX_DOT_CONFIG_SED += s:^(CT_TARGET_VENDOR)=.*:\1="unknown":;
+CTNG_FIX_DOT_CONFIG_SED += s:^(CT_TARGET_VENDOR)=.*:\1="buildroot":;
 CTNG_FIX_DOT_CONFIG_SED += s:^(CT_TARGET_ALIAS)=.*:\1="$(ARCH)-linux":;
 CTNG_FIX_DOT_CONFIG_SED += s:^(CT_TOOLCHAIN_PKGVERSION)="(.*)":\1="buildroot $(BR2_VERSION_FULL)":;
 ifneq ($(call qstrip,$(BR2_USE_MMU)),)