Patchwork [U-Boot,V4,2/3] FAT: initialize all fields in cur_part_info, simplify init

login
register
mail settings
Submitter Stephen Warren
Date Oct. 17, 2012, 4:44 p.m.
Message ID <1350492299-4342-2-git-send-email-swarren@wwwdotorg.org>
Download mbox | patch
Permalink /patch/192103/
State Accepted
Delegated to: Tom Rini
Headers show

Comments

Stephen Warren - Oct. 17, 2012, 4:44 p.m.
From: Stephen Warren <swarren@nvidia.com>

cur_part_info.{name,type} are strings. So, we don't need to memset()
the entire thing, just put the NULL-termination in the first byte.

Add missing initialization of the bootable and uuid fields.

None of these fields are actually used by fat.c. However, since it
stores the entire disk_partition_t, we should make sure that all fields
are valid.

Signed-off-by: Stephen Warren <swarren@nvidia.com>
Reviewed-by: Benoît Thébaudeau <benoit.thebaudeau@advansee.com>
---
v4: No change (just rebased).
v3: New patch.
---
 fs/fat/fat.c |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

Patch

diff --git a/fs/fat/fat.c b/fs/fat/fat.c
index b038baf..425aec7 100644
--- a/fs/fat/fat.c
+++ b/fs/fat/fat.c
@@ -92,8 +92,12 @@  int fat_register_device(block_dev_desc_t * dev_desc, int part_no)
 		cur_part_info.start = 0;
 		cur_part_info.size = dev_desc->lba;
 		cur_part_info.blksz = dev_desc->blksz;
-		memset(cur_part_info.name, 0, sizeof(cur_part_info.name));
-		memset(cur_part_info.type, 0, sizeof(cur_part_info.type));
+		cur_part_info.name[0] = 0;
+		cur_part_info.type[0] = 0;
+		cur_part_info.bootable = 0;
+#ifdef CONFIG_PARTITION_UUIDS
+		cur_part_info.uuid[0] = 0;
+#endif
 	}
 
 	/* Make sure it has a valid FAT header */