| Message ID | 1350480554-23281-8-git-send-email-kraxel@redhat.com |
|---|---|
| State | New |
| Headers | show |
On Wed, 17 Oct 2012, Gerd Hoffmann wrote: > Currently it is inconstent, PixelFormat->amask is left unset whereas > abits and amax and ashift are filled. As an alpha channel doesn't make > sense for the vga framebuffer leave all alpha fields clear. > > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> Actually the alpha mask was left to 0 on purpose to ignore it. At the same time we set amax, ashift and abits to signal the presence of an alpha byte in the pixel format. > console.c | 3 --- > 1 files changed, 0 insertions(+), 3 deletions(-) > > diff --git a/console.c b/console.c > index 48d88e4..d28b75e 100644 > --- a/console.c > +++ b/console.c > @@ -1715,18 +1715,15 @@ PixelFormat qemu_default_pixelformat(int bpp) > pf.rmask = 0x00FF0000; > pf.gmask = 0x0000FF00; > pf.bmask = 0x000000FF; > - pf.amax = 255; > pf.rmax = 255; > pf.gmax = 255; > pf.bmax = 255; > - pf.ashift = 24; > pf.rshift = 16; > pf.gshift = 8; > pf.bshift = 0; > pf.rbits = 8; > pf.gbits = 8; > pf.bbits = 8; > - pf.abits = 8; > break; > default: > break; > -- > 1.7.1 > >
On 10/19/12 19:02, Stefano Stabellini wrote: > On Wed, 17 Oct 2012, Gerd Hoffmann wrote: >> Currently it is inconstent, PixelFormat->amask is left unset whereas >> abits and amax and ashift are filled. As an alpha channel doesn't make >> sense for the vga framebuffer leave all alpha fields clear. >> >> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> > > Actually the alpha mask was left to 0 on purpose to ignore it. > At the same time we set amax, ashift and abits to signal the presence of > an alpha byte in the pixel format. Hmm? I still don't see t he point of the current mix. Either the byte is alpha or it is unused ... cheers, Gerd
diff --git a/console.c b/console.c index 48d88e4..d28b75e 100644 --- a/console.c +++ b/console.c @@ -1715,18 +1715,15 @@ PixelFormat qemu_default_pixelformat(int bpp) pf.rmask = 0x00FF0000; pf.gmask = 0x0000FF00; pf.bmask = 0x000000FF; - pf.amax = 255; pf.rmax = 255; pf.gmax = 255; pf.bmax = 255; - pf.ashift = 24; pf.rshift = 16; pf.gshift = 8; pf.bshift = 0; pf.rbits = 8; pf.gbits = 8; pf.bbits = 8; - pf.abits = 8; break; default: break;
Currently it is inconstent, PixelFormat->amask is left unset whereas abits and amax and ashift are filled. As an alpha channel doesn't make sense for the vga framebuffer leave all alpha fields clear. Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> --- console.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-)