mbox

[Quantal,SRU,pull-request] Cypress PS/2 Trackpad updates

Message ID 507E06D5.2080204@gmail.com
State New
Headers show

Pull-request

git://kernel.ubuntu.com/kamal/ubuntu-quantal.git cypress-update

Message

git@status.e4ward.com Oct. 17, 2012, 1:16 a.m. UTC 
Bug references:
	https://bugs.launchpad.net/dell-sputnik/+bug/1048258
	Cypress trackpad gets psmouse lost sync / driver resynced warnings

	https://bugs.launchpad.net/dell-sputnik/+bug/1064086
	Cypress trackpad: Occasional taps leak through as clicks even with tap-to-click disabled

[IMPACT]

This patch fixes a couple of issues with the new Cypress PS/2 Trackpad driver.
One issue is that the trackpad loses synchronization upon palm contact, and
the other is that, even with tap-to-click disabled, occasional taps get
interpreted as clicks.

[TESTCASE]

1. Disable tap-to-click in Mouse and Touchpad settings.
2. tail -f /var/log/kern.log
3. Touch palm to trackpad. Notice lost sync/resync messages.
4. Remove palm. Notice no more lost sync/resync messages.
5. Repeatedly tap (don't depress clickpad) on the bottom edge/corners
   of the trackpad. Notice the occasional click.
6. Test 3-5 with patch applied. Notice no more lost sync/resync
   messages upon palm contact, and no more occasional taps turning
   into clicks.

[Regression Potential]

None known. This patch affects only the Cypress PS/2 Trackpad driver.

----------

The following changes since commit 88462b831ac44b23828658656f382ac9084c9dbc:

  Linux 3.5.7 (2012-10-12 17:15:27 -0700)

are available in the git repository at:

  git://kernel.ubuntu.com/kamal/ubuntu-quantal.git cypress-update

for you to fetch changes up to 2c784f58a671b56cceba67d22093420e44dd3ada:

  UBUNTU: SAUCE: input: Cypress PS/2 Trackpad list additional contributors (2012-10-15 11:00:46 -0700)

----------------------------------------------------------------
Kamal Mostafa (1):
      UBUNTU: SAUCE: input: Cypress PS/2 Trackpad list additional contributors

Kyle Fazzari (2):
      UBUNTU: SAUCE: input: Cypress PS/2 Trackpad fix lost sync upon palm contact
      UBUNTU: SAUCE: input: Cypress PS/2 Trackpad fix taps turning into hardware clicks

 drivers/input/mouse/cypress_ps2.c |   13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

Comments

Tim Gardner Oct. 17, 2012, 12:39 p.m. UTC | #1 
Need some BugLink repair, e.g.,

BugLink: http://bugs.launchpad.net/bugs/1048258
Herton Ronaldo Krzesinski Oct. 17, 2012, 2:57 p.m. UTC | #2
Tim Gardner Oct. 18, 2012, 4:28 p.m. UTC | #3