From patchwork Wed Oct 17 10:55:36 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthew Gretton-Dann X-Patchwork-Id: 192013 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 83E402C0091 for ; Wed, 17 Oct 2012 21:55:55 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1351076156; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:From:To:Cc:Subject:Date:Message-ID:User-Agent: MIME-Version:Content-Type:Content-Transfer-Encoding:Mailing-List: Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:Sender:Delivered-To; bh=DE+7xXxv7Mv8aE0rmO7tZFybTio=; b=Pt9M7SLkPYaTb8ZNYYUNwxNohooSVWEnIny0p9Wck+2YyS1Qilpv/sF/VXzClX eFYkzRzrQHl8NtWgNB0nTIGNWYZHHubHr8NIzlEaDQBbjeQJmCvSqXPqxIpuHQRq uiBvOhLGcPfwtebwC0HySLENVROCJqTs8TljN3tvV95lY= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:X-Google-DKIM-Signature:Received:Received:From:To:Cc:Subject:Date:Message-ID:User-Agent:MIME-Version:Content-Type:Content-Transfer-Encoding:X-Gm-Message-State:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=UrNI3fEfwsaHVyUBAWz9WzButWfSrdgC2asA7F24FzeLLO2qbGD+FWU0SNjhnN sZikKtS6z3HVKD0QxJe8Q3bVoyej1BiodLb6IsoX7HT2bLgX0nzFUIoR7NmJNCHE fr+il9JVmnwfewp1/4tbwIrqE5VHSH82P/9amdMoGPELM=; Received: (qmail 6800 invoked by alias); 17 Oct 2012 10:55:51 -0000 Received: (qmail 6791 invoked by uid 22791); 17 Oct 2012 10:55:51 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=BAYES_00, KHOP_RCVD_UNTRUST, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-wi0-f179.google.com (HELO mail-wi0-f179.google.com) (209.85.212.179) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 17 Oct 2012 10:55:45 +0000 Received: by mail-wi0-f179.google.com with SMTP id hq7so382249wib.8 for ; Wed, 17 Oct 2012 03:55:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:user-agent:mime-version :content-type:content-transfer-encoding:x-gm-message-state; bh=pLQXJDLdsLssSUqS5dD18wlnPLzj6FErC4b6IxRi4jg=; b=oZ1vn+Tmy+LPx2vpzKv1M9EdWqKrnlDeyEH67JPSTTDlmixZV4aDCRtLzkJ7wbz9aW lOXt1YzXy/4GYTpBVtrRTls/5uyN4XR19zpb8ZT417mo9n/yqgjCBIvgxf1fums2gYg+ atM0D9IlnJmRE+mbewumjpCog2iQG9L7CvXVCc6nhL9waTII04feeTKeQvNS2QpWlOCF QvSmOHeEYsgbw8ATQh6m9gq/YxBa15bCpHknrbigup0goyKk402QFEKYVkP1Es1JhBY7 XRz9NAXf7PrXdrX5hBV/hn5/AxV+Ba278Pjt+RRNre/CJo4xHcTL85+/Yrv52s75TMXj h2xA== Received: by 10.216.210.16 with SMTP id t16mr10808478weo.175.1350471344154; Wed, 17 Oct 2012 03:55:44 -0700 (PDT) Received: from e103209-lin.localnet ([146.90.87.227]) by mx.google.com with ESMTPS id fp6sm3703734wib.0.2012.10.17.03.55.43 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 17 Oct 2012 03:55:43 -0700 (PDT) From: Matthew Gretton-Dann To: gcc-patches@gcc.gnu.org Cc: rearnsha@arm.com, rguenther@suse.de, patches@linaro.org Subject: [RFA ARM/4.7] Backport Split all insns before pool placement Date: Wed, 17 Oct 2012 11:55:36 +0100 Message-ID: <168827293.One0uaPfNY@e103209-lin> User-Agent: KMail/4.8.5 (Linux/3.2.0-31-generic; KDE/4.8.5; x86_64; ; ) MIME-Version: 1.0 X-Gm-Message-State: ALoCoQn6OWouVPgo/xIhTRt1thwru9Wg07+5meL3NbKYtG/uPlEFBE479VYSZzArugEJWaCLgzvC X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org All, Ulrich posted the following patch in July: http://gcc.gnu.org/ml/gcc-patches/2012-07/msg01123.html Richard E requested that it be left in testing on trunk for a couple of days before being backported to 4.7. Three months seems to satisfy the 'couple of days' requirement :-). Is this OK to be backported to 4.7? Cross tested arm-none-linux-gnueabi. Thanks, Matt 2012-10-15 Matthew Gretton-Dann Backported from mainline 2012-07-23 Ulrich Weigand * config/arm/arm.c (arm_reorg): Ensure all insns are split. diff --git a/gcc/config/arm/arm.c b/gcc/config/arm/arm.c index 35b73c5..3796a80 100644 --- a/gcc/config/arm/arm.c +++ b/gcc/config/arm/arm.c @@ -13337,6 +13337,13 @@ arm_reorg (void) if (TARGET_THUMB2) thumb2_reorg (); + /* Ensure all insns that must be split have been split at this point. + Otherwise, the pool placement code below may compute incorrect + insn lengths. Note that when optimizing, all insns have already + been split at this point. */ + if (!optimize) + split_all_insns_noflow (); + minipool_fix_head = minipool_fix_tail = NULL; /* The first insn must always be a note, or the code below won't