Patchwork [4/4] netfilter: xt_TEE: don't use destination address found in header

mail settings
Submitter Pablo Neira
Date Oct. 17, 2012, 10:40 a.m.
Message ID <>
Download mbox | patch
Permalink /patch/192008/
State Accepted
Headers show


Pablo Neira - Oct. 17, 2012, 10:40 a.m.
From: Eric Dumazet <>

Torsten Luettgert bisected TEE regression starting with commit
f8126f1d5136be1 (ipv4: Adjust semantics of rt->rt_gateway.)

The problem is that it tries to ARP-lookup the original destination
address of the forwarded packet, not the address of the gateway.

Fix this using FLOWI_FLAG_KNOWN_NH Julian added in commit
c92b96553a80c1 (ipv4: Add FLOWI_FLAG_KNOWN_NH), so that known
nexthop (info->gw.ip) has preference on resolving.

Reported-by: Torsten Luettgert <>
Bisected-by: Torsten Luettgert <>
Tested-by: Torsten Luettgert <>
Cc: Julian Anastasov <>
Signed-off-by: Eric Dumazet <>
Signed-off-by: Pablo Neira Ayuso <>
 net/netfilter/xt_TEE.c |    1 +
 1 file changed, 1 insertion(+)


diff --git a/net/netfilter/xt_TEE.c b/net/netfilter/xt_TEE.c
index ee2e5bc..bd93e51 100644
--- a/net/netfilter/xt_TEE.c
+++ b/net/netfilter/xt_TEE.c
@@ -70,6 +70,7 @@  tee_tg_route4(struct sk_buff *skb, const struct xt_tee_tginfo *info)
 	fl4.daddr = info->gw.ip;
 	fl4.flowi4_tos = RT_TOS(iph->tos);
 	fl4.flowi4_scope = RT_SCOPE_UNIVERSE;
+	fl4.flowi4_flags = FLOWI_FLAG_KNOWN_NH;
 	rt = ip_route_output_key(net, &fl4);
 	if (IS_ERR(rt))
 		return false;