From patchwork Sun Jan 18 15:52:31 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "J. K. Cliburn" X-Patchwork-Id: 19188 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id BB9B9DE072 for ; Mon, 19 Jan 2009 02:52:43 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933562AbZARPwi (ORCPT ); Sun, 18 Jan 2009 10:52:38 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933551AbZARPwh (ORCPT ); Sun, 18 Jan 2009 10:52:37 -0500 Received: from mail-gx0-f21.google.com ([209.85.217.21]:37426 "EHLO mail-gx0-f21.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933064AbZARPwg (ORCPT ); Sun, 18 Jan 2009 10:52:36 -0500 Received: by gxk14 with SMTP id 14so2198911gxk.13 for ; Sun, 18 Jan 2009 07:52:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:in-reply-to:references:x-mailer:mime-version :content-type:content-transfer-encoding; bh=mWdSpuUPiYKRwXZJbwoKUlHSstSNfj86sOoxp5hDXH0=; b=YtYc6TUg02Ce46i4aayFDsxIj+kjP9MP2IPaM6LCpLGWdTFZ/nseEdPihw9Qe+WN1W UhW8TTtknvhkzb1JYHadzol0cxyZfMg/ptzD53dGAixuEBZBXXWsaJqy5ch1Awsv5StP 7T3VKCiwWBTmF8K2TlGaAxUllVZSfvIHSEQZc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:in-reply-to:references:x-mailer :mime-version:content-type:content-transfer-encoding; b=Z6aRYZvr9tiZRVrSdEIyTMM/w3VQfe9vwpaSy5Q27wgO6sWfvh7V3TfXtpGKZbeK21 lO9vVTRPcuhxIUkGDny0W7M4am0HCVNjgPLF+MiJ2hzqeIM9L/4ujf9KNhPTUQq1EPIk q5uKwusKyltS1Yxjpd44DFtICYC38tac5JZNQ= Received: by 10.151.8.8 with SMTP id l8mr5378754ybi.30.1232293954831; Sun, 18 Jan 2009 07:52:34 -0800 (PST) Received: from osprey.hogchain.net (adsl-227-55-226.jan.bellsouth.net [74.227.55.226]) by mx.google.com with ESMTPS id j4sm6327224rne.5.2009.01.18.07.52.32 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 18 Jan 2009 07:52:33 -0800 (PST) Date: Sun, 18 Jan 2009 09:52:31 -0600 From: Jay Cliburn To: Sitsofe Wheeler Cc: linux-kernel@vger.kernel.org, Chris Snook , jie.yang@atheros.com, atl1-devel@lists.sourceforge.net, netdev@vger.kernel.org Subject: Re: [atl2] warn_slowpath in dev_watchdog Message-ID: <20090118095231.2c73c448@osprey.hogchain.net> In-Reply-To: <767752.95325.qm@web110601.mail.gq1.yahoo.com> References: <20090117194045.649f55a0@osprey.hogchain.net> <767752.95325.qm@web110601.mail.gq1.yahoo.com> X-Mailer: Claws Mail 3.6.1 (GTK+ 2.12.12; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, 18 Jan 2009 02:18:33 -0800 (PST) Sitsofe Wheeler wrote: > Hi, > > > > From: Jay Cliburn > > > > On Sat, 17 Jan 2009 18:49:18 +0000 (UTC) > > Sitsofe Wheeler wrote: > > > > > On an ever so slightly modified 2.6.28. I think this only happens > > > when the upstream router/switch goes out to lunch and packets are > > > being sent. It is reproducible but only appears on a home > > > network... > > > > > > [ 204.704065] ------------[ cut here ]------------ > > > [ 204.704074] WARNING: at net/sched/sch_generic.c:226 > > > dev_watchdog +0x22b/0x240() > > > [ 204.704080] NETDEV WATCHDOG: eth0 (atl2): transmit timed out > > > > Please provide your complete dmesg output. > > Unfortunately I only saved that snippet of the log (I can provide you > a full dmesg but it won't be from a run where this problem occured). I'd like to see the full dmesg that includes the warning, if you can obtain it next time it occurs. Meanwhile, please see if this patch helps. --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/atlx/atl2.c b/drivers/net/atlx/atl2.c index 8571e8c..376226c 100644 --- a/drivers/net/atlx/atl2.c +++ b/drivers/net/atlx/atl2.c @@ -555,14 +555,18 @@ static void atl2_check_for_link(struct atl2_adapter *adapter) atl2_read_phy_reg(&adapter->hw, MII_BMSR, &phy_data); spin_unlock(&adapter->stats_lock); - /* notify upper layer link down ASAP */ if (!(phy_data & BMSR_LSTATUS)) { /* Link Down */ - if (netif_carrier_ok(netdev)) { /* old link state: Up */ - printk(KERN_INFO "%s: %s NIC Link is Down\n", - atl2_driver_name, netdev->name); - adapter->link_speed = SPEED_0; - netif_carrier_off(netdev); - netif_stop_queue(netdev); + if (netif_carrier_ok(netdev)) { + /* + * Notify the upper layer and restart the netdev + * watchdog timer while we try to recover the link. + */ + netif_carrier_off(netdev); + netif_stop_queue(netdev); + netdev->trans_start = jiffies; + printk(KERN_INFO "%s: %s NIC Link is Down\n", + atl2_driver_name, netdev->name); + adapter->link_speed = SPEED_0; } } schedule_work(&adapter->link_chg_task);