Patchwork [08/11] lib: fwts_hwinfo: constify function arguments where appropriate

login
register
mail settings
Submitter Colin King
Date Oct. 16, 2012, 7:20 p.m.
Message ID <1350415248-16965-9-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/191862/
State Accepted
Headers show

Comments

Colin King - Oct. 16, 2012, 7:20 p.m.
From: Colin Ian King <colin.king@canonical.com>

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/lib/src/fwts_hwinfo.c |   13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)
Keng-Yu Lin - Oct. 18, 2012, 6:50 a.m.
On Wed, Oct 17, 2012 at 3:20 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/lib/src/fwts_hwinfo.c |   13 +++++++++++--
>  1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/src/lib/src/fwts_hwinfo.c b/src/lib/src/fwts_hwinfo.c
> index e03df6a..995df6c 100644
> --- a/src/lib/src/fwts_hwinfo.c
> +++ b/src/lib/src/fwts_hwinfo.c
> @@ -66,7 +66,11 @@ static void fwts_hwinfo_list_dump(fwts_framework *fw, fwts_list *list)
>   *  fwts_hwinfo_lists_dump()
>   *     dump out contents of two different lists
>   */
> -static void fwts_hwinfo_lists_dump(fwts_framework *fw, fwts_list *l1, fwts_list *l2, char *message)
> +static void fwts_hwinfo_lists_dump(
> +       fwts_framework *fw,
> +       fwts_list *l1,
> +       fwts_list *l2,
> +       const char *message)
>  {
>         fwts_log_info(fw, "%s configurations differ, before:", message);
>         fwts_hwinfo_list_dump(fw, l1);
> @@ -170,7 +174,12 @@ static int fwts_hwinfo_lists_differ(fwts_list *l1, fwts_list *l2)
>   *  fwts_hwinfo_compare()
>   *     check for differences in a list and if any found, dump out both lists
>   */
> -static void fwts_hwinfo_lists_compare(fwts_framework *fw, fwts_list *l1, fwts_list *l2, char *message, int *differences)
> +static void fwts_hwinfo_lists_compare(
> +       fwts_framework *fw,
> +       fwts_list *l1,
> +       fwts_list *l2,
> +       const char *message,
> +       int *differences)
>  {
>         if (fwts_hwinfo_lists_differ(l1, l2) == FWTS_HWINFO_LISTS_DIFFER) {
>                 (*differences)++;
> --
> 1.7.10.4
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Ivan Hu - Oct. 22, 2012, 9:33 a.m.
On 10/17/2012 03:20 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/lib/src/fwts_hwinfo.c |   13 +++++++++++--
>   1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/src/lib/src/fwts_hwinfo.c b/src/lib/src/fwts_hwinfo.c
> index e03df6a..995df6c 100644
> --- a/src/lib/src/fwts_hwinfo.c
> +++ b/src/lib/src/fwts_hwinfo.c
> @@ -66,7 +66,11 @@ static void fwts_hwinfo_list_dump(fwts_framework *fw, fwts_list *list)
>    *  fwts_hwinfo_lists_dump()
>    *	dump out contents of two different lists
>    */
> -static void fwts_hwinfo_lists_dump(fwts_framework *fw, fwts_list *l1, fwts_list *l2, char *message)
> +static void fwts_hwinfo_lists_dump(
> +	fwts_framework *fw,
> +	fwts_list *l1,
> +	fwts_list *l2,
> +	const char *message)
>   {
>   	fwts_log_info(fw, "%s configurations differ, before:", message);
>   	fwts_hwinfo_list_dump(fw, l1);
> @@ -170,7 +174,12 @@ static int fwts_hwinfo_lists_differ(fwts_list *l1, fwts_list *l2)
>    *  fwts_hwinfo_compare()
>    *	check for differences in a list and if any found, dump out both lists
>    */
> -static void fwts_hwinfo_lists_compare(fwts_framework *fw, fwts_list *l1, fwts_list *l2, char *message, int *differences)
> +static void fwts_hwinfo_lists_compare(
> +	fwts_framework *fw,
> +	fwts_list *l1,
> +	fwts_list *l2,
> +	const char *message,
> +	int *differences)
>   {
>   	if (fwts_hwinfo_lists_differ(l1, l2) == FWTS_HWINFO_LISTS_DIFFER) {
>   		(*differences)++;
>

Acked-by: Ivan Hu <ivan.hu@canonical.com>

Patch

diff --git a/src/lib/src/fwts_hwinfo.c b/src/lib/src/fwts_hwinfo.c
index e03df6a..995df6c 100644
--- a/src/lib/src/fwts_hwinfo.c
+++ b/src/lib/src/fwts_hwinfo.c
@@ -66,7 +66,11 @@  static void fwts_hwinfo_list_dump(fwts_framework *fw, fwts_list *list)
  *  fwts_hwinfo_lists_dump()
  *	dump out contents of two different lists
  */
-static void fwts_hwinfo_lists_dump(fwts_framework *fw, fwts_list *l1, fwts_list *l2, char *message)
+static void fwts_hwinfo_lists_dump(
+	fwts_framework *fw,
+	fwts_list *l1,
+	fwts_list *l2,
+	const char *message)
 {
 	fwts_log_info(fw, "%s configurations differ, before:", message);
 	fwts_hwinfo_list_dump(fw, l1);
@@ -170,7 +174,12 @@  static int fwts_hwinfo_lists_differ(fwts_list *l1, fwts_list *l2)
  *  fwts_hwinfo_compare()
  *	check for differences in a list and if any found, dump out both lists
  */
-static void fwts_hwinfo_lists_compare(fwts_framework *fw, fwts_list *l1, fwts_list *l2, char *message, int *differences)
+static void fwts_hwinfo_lists_compare(
+	fwts_framework *fw,
+	fwts_list *l1,
+	fwts_list *l2,
+	const char *message,
+	int *differences)
 {
 	if (fwts_hwinfo_lists_differ(l1, l2) == FWTS_HWINFO_LISTS_DIFFER) {
 		(*differences)++;