Patchwork [03/11] lib: fwts_acpi_tables: constify func arguments where appropriate

login
register
mail settings
Submitter Colin King
Date Oct. 16, 2012, 7:20 p.m.
Message ID <1350415248-16965-4-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/191857/
State Accepted
Headers show

Comments

Colin King - Oct. 16, 2012, 7:20 p.m.
From: Colin Ian King <colin.king@canonical.com>

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/lib/src/fwts_acpi_tables.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
Keng-Yu Lin - Oct. 18, 2012, 6:48 a.m.
On Wed, Oct 17, 2012 at 3:20 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/lib/src/fwts_acpi_tables.c |    7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/src/lib/src/fwts_acpi_tables.c b/src/lib/src/fwts_acpi_tables.c
> index f388cdd..e225a37 100644
> --- a/src/lib/src/fwts_acpi_tables.c
> +++ b/src/lib/src/fwts_acpi_tables.c
> @@ -157,7 +157,8 @@ static void fwts_acpi_add_table(
>         const void *table,                      /* Table binary blob */
>         const uint64_t addr,                    /* Address of table */
>         const size_t length,                    /* Length of table */
> -       fwts_acpi_table_provenance provenance)  /* Where we got the table from */
> +       const fwts_acpi_table_provenance provenance)
> +                                               /* Where we got the table from */
>  {
>         int i;
>         int which = 0;
> @@ -209,7 +210,7 @@ static void fwts_acpi_handle_fadt_tables(
>         fwts_acpi_table_fadt *fadt,
>         const uint32_t *addr32,
>         const uint64_t *addr64,
> -       fwts_acpi_table_provenance provenance)
> +       const fwts_acpi_table_provenance provenance)
>  {
>         off_t addr;
>         fwts_acpi_table_header *header;
> @@ -307,7 +308,7 @@ static int fwts_acpi_load_tables_from_firmware(void)
>   *     Loading tables from file may result in data without an originating
>   *     physical address of the table, so fake a unique 32 bit address for the table.
>   */
> -static uint32_t fwts_fake_physical_addr(size_t size)
> +static uint32_t fwts_fake_physical_addr(const size_t size)
>  {
>         static uint32_t fake_phys_addr = 0xbff00000;
>         uint32_t addr = fake_phys_addr;
> --
> 1.7.10.4
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Ivan Hu - Oct. 22, 2012, 9:31 a.m.
On 10/17/2012 03:20 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/lib/src/fwts_acpi_tables.c |    7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/src/lib/src/fwts_acpi_tables.c b/src/lib/src/fwts_acpi_tables.c
> index f388cdd..e225a37 100644
> --- a/src/lib/src/fwts_acpi_tables.c
> +++ b/src/lib/src/fwts_acpi_tables.c
> @@ -157,7 +157,8 @@ static void fwts_acpi_add_table(
>   	const void *table,			/* Table binary blob */
>   	const uint64_t addr,			/* Address of table */
>   	const size_t length,			/* Length of table */
> -	fwts_acpi_table_provenance provenance)	/* Where we got the table from */
> +	const fwts_acpi_table_provenance provenance)
> +						/* Where we got the table from */
>   {
>   	int i;
>   	int which = 0;
> @@ -209,7 +210,7 @@ static void fwts_acpi_handle_fadt_tables(
>   	fwts_acpi_table_fadt *fadt,
>   	const uint32_t *addr32,
>   	const uint64_t *addr64,
> -	fwts_acpi_table_provenance provenance)
> +	const fwts_acpi_table_provenance provenance)
>   {
>   	off_t addr;
>   	fwts_acpi_table_header *header;
> @@ -307,7 +308,7 @@ static int fwts_acpi_load_tables_from_firmware(void)
>    *	Loading tables from file may result in data without an originating
>    *	physical address of the table, so fake a unique 32 bit address for the table.
>    */
> -static uint32_t fwts_fake_physical_addr(size_t size)
> +static uint32_t fwts_fake_physical_addr(const size_t size)
>   {
>   	static uint32_t fake_phys_addr = 0xbff00000;
>   	uint32_t addr = fake_phys_addr;
>

Acked-by: Ivan Hu <ivan.hu@canonical.com>

Patch

diff --git a/src/lib/src/fwts_acpi_tables.c b/src/lib/src/fwts_acpi_tables.c
index f388cdd..e225a37 100644
--- a/src/lib/src/fwts_acpi_tables.c
+++ b/src/lib/src/fwts_acpi_tables.c
@@ -157,7 +157,8 @@  static void fwts_acpi_add_table(
 	const void *table,			/* Table binary blob */
 	const uint64_t addr,			/* Address of table */
 	const size_t length,			/* Length of table */
-	fwts_acpi_table_provenance provenance)	/* Where we got the table from */
+	const fwts_acpi_table_provenance provenance)
+						/* Where we got the table from */
 {
 	int i;
 	int which = 0;
@@ -209,7 +210,7 @@  static void fwts_acpi_handle_fadt_tables(
 	fwts_acpi_table_fadt *fadt,
 	const uint32_t *addr32,
 	const uint64_t *addr64,
-	fwts_acpi_table_provenance provenance)
+	const fwts_acpi_table_provenance provenance)
 {
 	off_t addr;
 	fwts_acpi_table_header *header;
@@ -307,7 +308,7 @@  static int fwts_acpi_load_tables_from_firmware(void)
  *	Loading tables from file may result in data without an originating
  *	physical address of the table, so fake a unique 32 bit address for the table.
  */
-static uint32_t fwts_fake_physical_addr(size_t size)
+static uint32_t fwts_fake_physical_addr(const size_t size)
 {
 	static uint32_t fake_phys_addr = 0xbff00000;
 	uint32_t addr = fake_phys_addr;