Patchwork uefi: uefidump: remove FWTS_FLAG_UNSAFE from test.

login
register
mail settings
Submitter Colin King
Date Oct. 16, 2012, 9:38 a.m.
Message ID <1350380285-26893-1-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/191759/
State Accepted
Headers show

Comments

Colin King - Oct. 16, 2012, 9:38 a.m.
From: Colin Ian King <colin.king@canonical.com>

Commit cdd817599787055dd4a20def83d4853b62ee854c mistakenly
set this test as an unsafe test.  Set it back to a normal utility
test.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/uefi/uefidump/uefidump.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Keng-Yu Lin - Oct. 17, 2012, 8:20 a.m.
On Tue, Oct 16, 2012 at 5:38 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Commit cdd817599787055dd4a20def83d4853b62ee854c mistakenly
> set this test as an unsafe test.  Set it back to a normal utility
> test.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/uefi/uefidump/uefidump.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/uefi/uefidump/uefidump.c b/src/uefi/uefidump/uefidump.c
> index 11c40e9..99d270d 100644
> --- a/src/uefi/uefidump/uefidump.c
> +++ b/src/uefi/uefidump/uefidump.c
> @@ -780,4 +780,4 @@ static fwts_framework_ops uefidump_ops = {
>         .minor_tests = uefidump_tests
>  };
>
> -FWTS_REGISTER(uefidump, &uefidump_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_UNSAFE | FWTS_FLAG_ROOT_PRIV);
> +FWTS_REGISTER(uefidump, &uefidump_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_UTILS | FWTS_FLAG_ROOT_PRIV);
> --
> 1.7.10.4
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Ivan Hu - Oct. 22, 2012, 8:50 a.m.
On 10/16/2012 05:38 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Commit cdd817599787055dd4a20def83d4853b62ee854c mistakenly
> set this test as an unsafe test.  Set it back to a normal utility
> test.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/uefi/uefidump/uefidump.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/uefi/uefidump/uefidump.c b/src/uefi/uefidump/uefidump.c
> index 11c40e9..99d270d 100644
> --- a/src/uefi/uefidump/uefidump.c
> +++ b/src/uefi/uefidump/uefidump.c
> @@ -780,4 +780,4 @@ static fwts_framework_ops uefidump_ops = {
>   	.minor_tests = uefidump_tests
>   };
>
> -FWTS_REGISTER(uefidump, &uefidump_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_UNSAFE | FWTS_FLAG_ROOT_PRIV);
> +FWTS_REGISTER(uefidump, &uefidump_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_UTILS | FWTS_FLAG_ROOT_PRIV);
>

Acked-by: Ivan Hu <ivan.hu@canonical.com>

Patch

diff --git a/src/uefi/uefidump/uefidump.c b/src/uefi/uefidump/uefidump.c
index 11c40e9..99d270d 100644
--- a/src/uefi/uefidump/uefidump.c
+++ b/src/uefi/uefidump/uefidump.c
@@ -780,4 +780,4 @@  static fwts_framework_ops uefidump_ops = {
 	.minor_tests = uefidump_tests
 };
 
-FWTS_REGISTER(uefidump, &uefidump_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_UNSAFE | FWTS_FLAG_ROOT_PRIV);
+FWTS_REGISTER(uefidump, &uefidump_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_UTILS | FWTS_FLAG_ROOT_PRIV);