Patchwork fluxbox: select xmodmap

login
register
mail settings
Submitter Yegor Yefremov
Date Oct. 16, 2012, 6:49 a.m.
Message ID <1350370149-2876-1-git-send-email-yegorslists@googlemail.com>
Download mbox | patch
Permalink /patch/191731/
State Superseded
Headers show

Comments

Yegor Yefremov - Oct. 16, 2012, 6:49 a.m.
From: Yegor Yefremov <yegorslists@googlemail.com>

Fluxbox uses xmodmap in its startup script.

Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
 package/fluxbox/Config.in |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Thomas Petazzoni - Oct. 16, 2012, 5:24 p.m.
On Tue, 16 Oct 2012 08:49:09 +0200, yegorslists@googlemail.com wrote:

> @@ -3,6 +3,7 @@ config BR2_PACKAGE_FLUXBOX
>  	depends on BR2_PACKAGE_XORG7
>  	depends on BR2_INSTALL_LIBSTDCPP
>  	select BR2_PACKAGE_XLIB_LIBX11
> +	select BR2_PACKAGE_XAPP_XMODMAP
>  	help
>  	  The Fluxbox lightweight window manager for X

When a dependency like this is a runtime dependency, I generally like
to have a short comment on top of it. It's kind of likely that someone
will read fluxbox.mk, not see xmodmap in FLUXBOX_DEPENDENCIES, and
therefore wonder why this "select" is around. For sure, Git history is
here, but I think something like:

	# Runtime dependency, needed by startup script
	select BR2_PACKAGE_XAPP_XMODMAP

Doesn't harm too much and can be quite useful in the future.

Thanks!

Thomas
Yegor Yefremov - Oct. 16, 2012, 7:33 p.m.
On Tue, Oct 16, 2012 at 7:24 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
>
> On Tue, 16 Oct 2012 08:49:09 +0200, yegorslists@googlemail.com wrote:
>
>> @@ -3,6 +3,7 @@ config BR2_PACKAGE_FLUXBOX
>>       depends on BR2_PACKAGE_XORG7
>>       depends on BR2_INSTALL_LIBSTDCPP
>>       select BR2_PACKAGE_XLIB_LIBX11
>> +     select BR2_PACKAGE_XAPP_XMODMAP
>>       help
>>         The Fluxbox lightweight window manager for X
>
> When a dependency like this is a runtime dependency, I generally like
> to have a short comment on top of it. It's kind of likely that someone
> will read fluxbox.mk, not see xmodmap in FLUXBOX_DEPENDENCIES, and
> therefore wonder why this "select" is around. For sure, Git history is
> here, but I think something like:
>
>         # Runtime dependency, needed by startup script
>         select BR2_PACKAGE_XAPP_XMODMAP
>
> Doesn't harm too much and can be quite useful in the future.

O.K. Thanks for review. I will resend the patch.

Yegor

Patch

diff --git a/package/fluxbox/Config.in b/package/fluxbox/Config.in
index e4d6c37..7a3a255 100644
--- a/package/fluxbox/Config.in
+++ b/package/fluxbox/Config.in
@@ -3,6 +3,7 @@  config BR2_PACKAGE_FLUXBOX
 	depends on BR2_PACKAGE_XORG7
 	depends on BR2_INSTALL_LIBSTDCPP
 	select BR2_PACKAGE_XLIB_LIBX11
+	select BR2_PACKAGE_XAPP_XMODMAP
 	help
 	  The Fluxbox lightweight window manager for X