Patchwork [U-Boot,v1] ARM : Remove unused CONFIG_DRIVER_SMC91111, CONFIG_DRIVER_LAN91C96

login
register
mail settings
Submitter Ashok
Date Oct. 15, 2012, 5 p.m.
Message ID <507C411E.90505@gmail.com>
Download mbox | patch
Permalink /patch/191599/
State Accepted
Delegated to: Tom Rini
Headers show

Comments

Ashok - Oct. 15, 2012, 5 p.m.
Remove unused CONFIG_DRIVER_SMC91111,CONFIG_DRIVER_LAN91C96,
if required implement smc_set_mac_addr() in board init.

Signed-off-by: Ashok Kumar Reddy <ashokkourla2000@gmail.com>
---
Changes from v1:
	- Fixed typo

  arch/arm/lib/board.c |   17 -----------------
  1 file changed, 17 deletions(-)
Tom Rini - Oct. 15, 2012, 6:07 p.m.
On Mon, Oct 15, 2012 at 10:30:14PM +0530, Ashok Kumar Reddy wrote:

> Remove unused CONFIG_DRIVER_SMC91111,CONFIG_DRIVER_LAN91C96,
> if required implement smc_set_mac_addr() in board init.
> 
> Signed-off-by: Ashok Kumar Reddy <ashokkourla2000@gmail.com>
> ---
> Changes from v1:
> 	- Fixed typo

Note that you should change the subject to say 'v2' now.  You don't need
to resend, just please keep this in mind for future patches.

Acked-by: Tom Rini <trini@ti.com>
Tom Rini - Oct. 22, 2012, 9:05 p.m.
On Mon, Oct 15, 2012 at 10:30:14PM +0530, Ashok Kumar Reddy wrote:

> Remove unused CONFIG_DRIVER_SMC91111,CONFIG_DRIVER_LAN91C96,
> if required implement smc_set_mac_addr() in board init.
> 
> Signed-off-by: Ashok Kumar Reddy <ashokkourla2000@gmail.com>
> ---
> Changes from v1:
> 	- Fixed typo

Applied to u-boot/master, thanks!

Patch

diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c
index 109a1ac..cb71b02 100644
--- a/arch/arm/lib/board.c
+++ b/arch/arm/lib/board.c
@@ -57,13 +57,6 @@ 
  #include <miiphy.h>
  #endif

-#ifdef CONFIG_DRIVER_SMC91111
-#include "../drivers/net/smc91111.h"
-#endif
-#ifdef CONFIG_DRIVER_LAN91C96
-#include "../drivers/net/lan91c96.h"
-#endif
-
  DECLARE_GLOBAL_DATA_PTR;

  ulong monitor_flash_len;
@@ -593,16 +586,6 @@  void board_init_r(gd_t *id, ulong dest_addr)
      /* enable exceptions */
      enable_interrupts();

-    /* Perform network card initialisation if necessary */
-#if defined(CONFIG_DRIVER_SMC91111) || defined (CONFIG_DRIVER_LAN91C96)
-    /* XXX: this needs to be moved to board init */
-    if (getenv("ethaddr")) {
-        uchar enetaddr[6];
-        eth_getenv_enetaddr("ethaddr", enetaddr);
-        smc_set_mac_addr(enetaddr);
-    }
-#endif /* CONFIG_DRIVER_SMC91111 || CONFIG_DRIVER_LAN91C96 */
-
      /* Initialize from environment */
      load_addr = getenv_ulong("loadaddr", 16, load_addr);