Patchwork bios: hdaaudio: user pin configs should be dumping out user_pin_configs

login
register
mail settings
Submitter Colin King
Date Oct. 15, 2012, 8:28 a.m.
Message ID <1350289730-4877-1-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/191492/
State Rejected
Headers show

Comments

Colin King - Oct. 15, 2012, 8:28 a.m.
From: Colin Ian King <colin.king@canonical.com>

As Alex Hung pointed out, the user pin configuration dump should
be printing out the user_pin_configs and not the driver_pin_configs.
A cut-and-paste error. Doh.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/bios/hdaaudio/hdaaudio.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Colin King - Oct. 15, 2012, 8:31 a.m.
On 15/10/12 09:28, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> As Alex Hung pointed out, the user pin configuration dump should
> be printing out the user_pin_configs and not the driver_pin_configs.
> A cut-and-paste error. Doh.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/bios/hdaaudio/hdaaudio.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/bios/hdaaudio/hdaaudio.c b/src/bios/hdaaudio/hdaaudio.c
> index 764e18e..c8fd61c 100644
> --- a/src/bios/hdaaudio/hdaaudio.c
> +++ b/src/bios/hdaaudio/hdaaudio.c
> @@ -123,7 +123,7 @@ static int hda_audio_check_pins(fwts_framework *fw, const char *path)
>
>   	if (fwts_list_len(&user_pin_configs) > 0) {
>   		hda_audio_dump_pins(fw, "User defined pin configurations",
> -			&driver_pin_configs);
> +			&user_pin_configs);
>   		warn++;
>   	}
>
>
NAK - Alex got there before me :-)

Patch

diff --git a/src/bios/hdaaudio/hdaaudio.c b/src/bios/hdaaudio/hdaaudio.c
index 764e18e..c8fd61c 100644
--- a/src/bios/hdaaudio/hdaaudio.c
+++ b/src/bios/hdaaudio/hdaaudio.c
@@ -123,7 +123,7 @@  static int hda_audio_check_pins(fwts_framework *fw, const char *path)
 
 	if (fwts_list_len(&user_pin_configs) > 0) {
 		hda_audio_dump_pins(fw, "User defined pin configurations",
-			&driver_pin_configs);
+			&user_pin_configs);
 		warn++;
 	}