Patchwork bios: hdaaudio: fix user pin configurations (user_pin_configs) is not checked.

login
register
mail settings
Submitter Alex Hung
Date Oct. 15, 2012, 8:21 a.m.
Message ID <1350289262-22984-1-git-send-email-alex.hung@canonical.com>
Download mbox | patch
Permalink /patch/191490/
State Accepted
Headers show

Comments

Alex Hung - Oct. 15, 2012, 8:21 a.m.
Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
 src/bios/hdaaudio/hdaaudio.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Colin King - Oct. 15, 2012, 8:29 a.m.
On 15/10/12 09:21, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>   src/bios/hdaaudio/hdaaudio.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/bios/hdaaudio/hdaaudio.c b/src/bios/hdaaudio/hdaaudio.c
> index 764e18e..c8fd61c 100644
> --- a/src/bios/hdaaudio/hdaaudio.c
> +++ b/src/bios/hdaaudio/hdaaudio.c
> @@ -123,7 +123,7 @@ static int hda_audio_check_pins(fwts_framework *fw, const char *path)
>
>   	if (fwts_list_len(&user_pin_configs) > 0) {
>   		hda_audio_dump_pins(fw, "User defined pin configurations",
> -			&driver_pin_configs);
> +			&user_pin_configs);
>   		warn++;
>   	}
>
>
Acked-by: Colin Ian King <colin.king@canonical.com>
Keng-Yu Lin - Oct. 17, 2012, 8:17 a.m.
On Mon, Oct 15, 2012 at 4:21 PM, Alex Hung <alex.hung@canonical.com> wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/bios/hdaaudio/hdaaudio.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/bios/hdaaudio/hdaaudio.c b/src/bios/hdaaudio/hdaaudio.c
> index 764e18e..c8fd61c 100644
> --- a/src/bios/hdaaudio/hdaaudio.c
> +++ b/src/bios/hdaaudio/hdaaudio.c
> @@ -123,7 +123,7 @@ static int hda_audio_check_pins(fwts_framework *fw, const char *path)
>
>         if (fwts_list_len(&user_pin_configs) > 0) {
>                 hda_audio_dump_pins(fw, "User defined pin configurations",
> -                       &driver_pin_configs);
> +                       &user_pin_configs);
>                 warn++;
>         }
>
> --
> 1.7.9.5
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>

Patch

diff --git a/src/bios/hdaaudio/hdaaudio.c b/src/bios/hdaaudio/hdaaudio.c
index 764e18e..c8fd61c 100644
--- a/src/bios/hdaaudio/hdaaudio.c
+++ b/src/bios/hdaaudio/hdaaudio.c
@@ -123,7 +123,7 @@  static int hda_audio_check_pins(fwts_framework *fw, const char *path)
 
 	if (fwts_list_len(&user_pin_configs) > 0) {
 		hda_audio_dump_pins(fw, "User defined pin configurations",
-			&driver_pin_configs);
+			&user_pin_configs);
 		warn++;
 	}