Patchwork [v2] pkg-infra: add <pkg>-extract and <pkg>-patch targets to OVERRIDE support

login
register
mail settings
Submitter Arnout Vandecappelle
Date Oct. 14, 2012, 9:19 p.m.
Message ID <1350249558-21276-1-git-send-email-arnout@mind.be>
Download mbox | patch
Permalink /patch/191437/
State Accepted
Commit 054f97e1f2de337ea0c788d766212a36d6d4e41c
Headers show

Comments

Arnout Vandecappelle - Oct. 14, 2012, 9:19 p.m.
The legal-info target (and possibly others as well) depends on
<pkg>-extract to make sure the license file is available.  However,
when <PKG>_OVERRIDE_SRCDIR is active, the <pkg>-extract target
doesn't exist.

To solve this, we add <pkg>-extract which depends on <pkg>-rsync.
While we're at it,we do the same for <pkg>-patch.  That avoids the
same problem in the future if something starts depending on
<pkg>-patch.

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
v2: As ThomasP suggested, don't remove <pkg>-rsync.

 package/pkg-generic.mk |    3 +++
 1 file changed, 3 insertions(+)
Thomas Petazzoni - Oct. 14, 2012, 9:42 p.m.
On Sun, 14 Oct 2012 23:19:18 +0200, Arnout Vandecappelle
(Essensium/Mind) wrote:
> The legal-info target (and possibly others as well) depends on
> <pkg>-extract to make sure the license file is available.  However,
> when <PKG>_OVERRIDE_SRCDIR is active, the <pkg>-extract target
> doesn't exist.
> 
> To solve this, we add <pkg>-extract which depends on <pkg>-rsync.
> While we're at it,we do the same for <pkg>-patch.  That avoids the
> same problem in the future if something starts depending on
> <pkg>-patch.
> 
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Luca Ceresoli - Oct. 15, 2012, 12:38 p.m.
Arnout Vandecappelle (Essensium/Mind) wrote:
> The legal-info target (and possibly others as well) depends on
> <pkg>-extract to make sure the license file is available.  However,
> when <PKG>_OVERRIDE_SRCDIR is active, the <pkg>-extract target
> doesn't exist.
>
> To solve this, we add <pkg>-extract which depends on <pkg>-rsync.
> While we're at it,we do the same for <pkg>-patch.  That avoids the
> same problem in the future if something starts depending on
> <pkg>-patch.
>
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
> v2: As ThomasP suggested, don't remove <pkg>-rsync.
>
>   package/pkg-generic.mk |    3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
> index ffe7dfb..27db5a5 100644
> --- a/package/pkg-generic.mk
> +++ b/package/pkg-generic.mk
> @@ -380,6 +380,9 @@ $(1)-configure:		$(1)-depends \
>
>   $(1)-depends:		$(1)-rsync $$($(2)_DEPENDENCIES)
>
> +$(1)-patch:		$(1)-rsync
> +$(1)-extract:		$(1)-rsync
> +
>   $(1)-rsync:		$$($(2)_TARGET_RSYNC)
>
>   $(1)-source:		$$($(2)_TARGET_RSYNC_SOURCE)
>


Acked-by: Luca Ceresoli <luca@lucaceresoli.net>

Patch

diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
index ffe7dfb..27db5a5 100644
--- a/package/pkg-generic.mk
+++ b/package/pkg-generic.mk
@@ -380,6 +380,9 @@  $(1)-configure:		$(1)-depends \
 
 $(1)-depends:		$(1)-rsync $$($(2)_DEPENDENCIES)
 
+$(1)-patch:		$(1)-rsync
+$(1)-extract:		$(1)-rsync
+
 $(1)-rsync:		$$($(2)_TARGET_RSYNC)
 
 $(1)-source:		$$($(2)_TARGET_RSYNC_SOURCE)