Patchwork [10/10] libsoup: remove redundant dependency on gettext

login
register
mail settings
Submitter Arnout Vandecappelle
Date Oct. 14, 2012, 9:11 p.m.
Message ID <20121014211121.17845.45817.stgit@localhost>
Download mbox | patch
Permalink /patch/191433/
State Superseded
Headers show

Comments

Arnout Vandecappelle - Oct. 14, 2012, 9:11 p.m.
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
 package/libsoup/Config.in |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Yann E. MORIN - Oct. 14, 2012, 9:24 p.m.
Arnout, All,

On Sunday 14 October 2012 Arnout Vandecappelle (Essensium/Mind) wrote:
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
>  package/libsoup/Config.in |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/libsoup/Config.in b/package/libsoup/Config.in
> index 57b425f..219f822 100644
> --- a/package/libsoup/Config.in
> +++ b/package/libsoup/Config.in
> @@ -3,7 +3,7 @@ config BR2_PACKAGE_LIBSOUP
>  	depends on BR2_USE_WCHAR # glib2 and gnutls
>  	select BR2_PACKAGE_LIBXML2
>  	select BR2_PACKAGE_LIBGLIB2
> -	select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT
> +	select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE
>  	help
>  	  libsoup is an HTTP client/server library. It uses GObject
>  	  and the GLib main loop, to integrate well with GNOME

Ditto the glib-networking patch: the subject is misleading. Change to
something like:
    libsoup: only depends on gettext if locales are used

Or maybe you meant that gettext is needed by libglib2, not by libsoup
itself? In which case you want to remove the select altogether.

Regards,
Yann E. MORIN.
Arnout Vandecappelle - Nov. 1, 2012, 2:26 p.m.
On 10/14/12 23:24, Yann E. MORIN wrote:
> Or maybe you meant that gettext is needed by libglib2, not by libsoup
> itself? In which case you want to remove the select altogether.

  In fact, libsoup doesn't use libintl directly, but does use gi18n.  So
I guess the dependency can indeed be removed.

  Regards,
  Arnout

Patch

diff --git a/package/libsoup/Config.in b/package/libsoup/Config.in
index 57b425f..219f822 100644
--- a/package/libsoup/Config.in
+++ b/package/libsoup/Config.in
@@ -3,7 +3,7 @@  config BR2_PACKAGE_LIBSOUP
 	depends on BR2_USE_WCHAR # glib2 and gnutls
 	select BR2_PACKAGE_LIBXML2
 	select BR2_PACKAGE_LIBGLIB2
-	select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT
+	select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE
 	help
 	  libsoup is an HTTP client/server library. It uses GObject
 	  and the GLib main loop, to integrate well with GNOME