Patchwork [01/10] diffutils: only needs gettext if locale is selected

login
register
mail settings
Submitter Arnout Vandecappelle
Date Oct. 14, 2012, 9:09 p.m.
Message ID <20121014210912.17845.32770.stgit@localhost>
Download mbox | patch
Permalink /patch/191424/
State Superseded
Headers show

Comments

Arnout Vandecappelle - Oct. 14, 2012, 9:09 p.m.
Also add missing select in Config.in.

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
 package/diffutils/Config.in    |    1 +
 package/diffutils/diffutils.mk |    3 +--
 2 files changed, 2 insertions(+), 2 deletions(-)
Yann E. MORIN - Oct. 14, 2012, 9:25 p.m.
Arnout, All,

On Sunday 14 October 2012 Arnout Vandecappelle (Essensium/Mind) wrote:
> Also add missing select in Config.in.
> 
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

> ---
>  package/diffutils/Config.in    |    1 +
>  package/diffutils/diffutils.mk |    3 +--
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/diffutils/Config.in b/package/diffutils/Config.in
> index 86da5d3..4cc16e2 100644
> --- a/package/diffutils/Config.in
> +++ b/package/diffutils/Config.in
> @@ -1,6 +1,7 @@
>  config BR2_PACKAGE_DIFFUTILS
>  	bool"diffutils"
>  	depends on BR2_USE_WCHAR
> +	select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE
>  	help
>  	  GNU diff. Compare files per line.
>  
> diff --git a/package/diffutils/diffutils.mk b/package/diffutils/diffutils.mk
> index 168d040..2530763 100644
> --- a/package/diffutils/diffutils.mk
> +++ b/package/diffutils/diffutils.mk
> @@ -6,8 +6,7 @@
>  
>  DIFFUTILS_VERSION = 3.2
>  DIFFUTILS_SITE = $(BR2_GNU_MIRROR)/diffutils
> -DIFFUTILS_DEPENDENCIES = \
> -	$(if $(BR2_PACKAGE_GETTEXT),gettext)
> +DIFFUTILS_DEPENDENCIES = $(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),gettext)
>  
>  ifeq ($(BR2_PACKAGE_BUSYBOX),y)
>  DIFFUTILS_DEPENDENCIES += busybox
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
> 
>

Patch

diff --git a/package/diffutils/Config.in b/package/diffutils/Config.in
index 86da5d3..4cc16e2 100644
--- a/package/diffutils/Config.in
+++ b/package/diffutils/Config.in
@@ -1,6 +1,7 @@ 
 config BR2_PACKAGE_DIFFUTILS
 	bool"diffutils"
 	depends on BR2_USE_WCHAR
+	select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE
 	help
 	  GNU diff. Compare files per line.
 
diff --git a/package/diffutils/diffutils.mk b/package/diffutils/diffutils.mk
index 168d040..2530763 100644
--- a/package/diffutils/diffutils.mk
+++ b/package/diffutils/diffutils.mk
@@ -6,8 +6,7 @@ 
 
 DIFFUTILS_VERSION = 3.2
 DIFFUTILS_SITE = $(BR2_GNU_MIRROR)/diffutils
-DIFFUTILS_DEPENDENCIES = \
-	$(if $(BR2_PACKAGE_GETTEXT),gettext)
+DIFFUTILS_DEPENDENCIES = $(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),gettext)
 
 ifeq ($(BR2_PACKAGE_BUSYBOX),y)
 DIFFUTILS_DEPENDENCIES += busybox