Patchwork [20/26] pci: aspm: remove redundant parameter in pcie_check_aspm_registers

login
register
mail settings
Submitter Colin King
Date Oct. 14, 2012, 8:32 p.m.
Message ID <1350246738-31699-21-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/191407/
State Accepted
Headers show

Comments

Colin King - Oct. 14, 2012, 8:32 p.m.
From: Colin Ian King <colin.king@canonical.com>

Function pcie_check_aspm_registers has an unused redundant
parameter for the log level, so remove it.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/pci/aspm/aspm.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
Alex Hung - Oct. 15, 2012, 6:02 a.m.
On 10/15/2012 04:32 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Function pcie_check_aspm_registers has an unused redundant
> parameter for the log level, so remove it.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/pci/aspm/aspm.c |    5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/src/pci/aspm/aspm.c b/src/pci/aspm/aspm.c
> index 4211672..e6d91ca 100644
> --- a/src/pci/aspm/aspm.c
> +++ b/src/pci/aspm/aspm.c
> @@ -222,8 +222,7 @@ static void pci_device_list_free(struct pci_device *head)
>   	}
>   }
>
> -static int pcie_check_aspm_registers(fwts_framework *fw,
> -	const fwts_log_level level)
> +static int pcie_check_aspm_registers(fwts_framework *fw)
>   {
>   	fwts_list *lspci_output;
>   	fwts_list_link *item;
> @@ -338,7 +337,7 @@ static int aspm_check_configuration(fwts_framework *fw)
>
>   static int aspm_pcie_register_configuration(fwts_framework *fw)
>   {
> -	return pcie_check_aspm_registers(fw, LOG_LEVEL_HIGH);
> +	return pcie_check_aspm_registers(fw);
>   }
>
>   static fwts_framework_minor_test aspm_tests[] = {
>

Acked-by: Alex Hung <alex.hung@canonical.com>
Keng-Yu Lin - Oct. 17, 2012, 7:53 a.m.
On Mon, Oct 15, 2012 at 4:32 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Function pcie_check_aspm_registers has an unused redundant
> parameter for the log level, so remove it.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/pci/aspm/aspm.c |    5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/src/pci/aspm/aspm.c b/src/pci/aspm/aspm.c
> index 4211672..e6d91ca 100644
> --- a/src/pci/aspm/aspm.c
> +++ b/src/pci/aspm/aspm.c
> @@ -222,8 +222,7 @@ static void pci_device_list_free(struct pci_device *head)
>         }
>  }
>
> -static int pcie_check_aspm_registers(fwts_framework *fw,
> -       const fwts_log_level level)
> +static int pcie_check_aspm_registers(fwts_framework *fw)
>  {
>         fwts_list *lspci_output;
>         fwts_list_link *item;
> @@ -338,7 +337,7 @@ static int aspm_check_configuration(fwts_framework *fw)
>
>  static int aspm_pcie_register_configuration(fwts_framework *fw)
>  {
> -       return pcie_check_aspm_registers(fw, LOG_LEVEL_HIGH);
> +       return pcie_check_aspm_registers(fw);
>  }
>
>  static fwts_framework_minor_test aspm_tests[] = {
> --
> 1.7.10.4
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>

Patch

diff --git a/src/pci/aspm/aspm.c b/src/pci/aspm/aspm.c
index 4211672..e6d91ca 100644
--- a/src/pci/aspm/aspm.c
+++ b/src/pci/aspm/aspm.c
@@ -222,8 +222,7 @@  static void pci_device_list_free(struct pci_device *head)
 	}
 }
 
-static int pcie_check_aspm_registers(fwts_framework *fw,
-	const fwts_log_level level)
+static int pcie_check_aspm_registers(fwts_framework *fw)
 {
 	fwts_list *lspci_output;
 	fwts_list_link *item;
@@ -338,7 +337,7 @@  static int aspm_check_configuration(fwts_framework *fw)
 
 static int aspm_pcie_register_configuration(fwts_framework *fw)
 {
-	return pcie_check_aspm_registers(fw, LOG_LEVEL_HIGH);
+	return pcie_check_aspm_registers(fw);
 }
 
 static fwts_framework_minor_test aspm_tests[] = {