Patchwork [19/26] dmi: dmi_decode: failed_count should be uint32_t

login
register
mail settings
Submitter Colin King
Date Oct. 14, 2012, 8:32 p.m.
Message ID <1350246738-31699-20-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/191406/
State Accepted
Headers show

Comments

Colin King - Oct. 14, 2012, 8:32 p.m.
From: Colin Ian King <colin.king@canonical.com>

Declare failed_count as uint32_t to match the same type as
fw->minor_tests.failed

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/dmi/dmi_decode/dmi_decode.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Alex Hung - Oct. 15, 2012, 6 a.m.
On 10/15/2012 04:32 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Declare failed_count as uint32_t to match the same type as
> fw->minor_tests.failed
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/dmi/dmi_decode/dmi_decode.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/dmi/dmi_decode/dmi_decode.c b/src/dmi/dmi_decode/dmi_decode.c
> index ca307ef..aa1ce15 100644
> --- a/src/dmi/dmi_decode/dmi_decode.c
> +++ b/src/dmi/dmi_decode/dmi_decode.c
> @@ -443,7 +443,7 @@ static void dmi_decode_entry(fwts_framework *fw,
>   	char	*table;
>   	int	i;
>   	int 	len;
> -	int	failed_count = fw->minor_tests.failed;
> +	uint32_t failed_count = fw->minor_tests.failed;
>   	int	battery_count;
>   	int	ret;
>   	int	both_ok;
>

Acked-by: Alex Hung <alex.hung@canonical.com>
Keng-Yu Lin - Oct. 17, 2012, 7:53 a.m.
On Mon, Oct 15, 2012 at 4:32 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Declare failed_count as uint32_t to match the same type as
> fw->minor_tests.failed
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/dmi/dmi_decode/dmi_decode.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/dmi/dmi_decode/dmi_decode.c b/src/dmi/dmi_decode/dmi_decode.c
> index ca307ef..aa1ce15 100644
> --- a/src/dmi/dmi_decode/dmi_decode.c
> +++ b/src/dmi/dmi_decode/dmi_decode.c
> @@ -443,7 +443,7 @@ static void dmi_decode_entry(fwts_framework *fw,
>         char    *table;
>         int     i;
>         int     len;
> -       int     failed_count = fw->minor_tests.failed;
> +       uint32_t failed_count = fw->minor_tests.failed;
>         int     battery_count;
>         int     ret;
>         int     both_ok;
> --
> 1.7.10.4
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>

Patch

diff --git a/src/dmi/dmi_decode/dmi_decode.c b/src/dmi/dmi_decode/dmi_decode.c
index ca307ef..aa1ce15 100644
--- a/src/dmi/dmi_decode/dmi_decode.c
+++ b/src/dmi/dmi_decode/dmi_decode.c
@@ -443,7 +443,7 @@  static void dmi_decode_entry(fwts_framework *fw,
 	char	*table;
 	int	i;
 	int 	len;
-	int	failed_count = fw->minor_tests.failed;
+	uint32_t failed_count = fw->minor_tests.failed;
 	int	battery_count;
 	int	ret;
 	int	both_ok;