Patchwork [16/26] bios: bios_info: fix bug where product_serial was not being dumped

login
register
mail settings
Submitter Colin King
Date Oct. 14, 2012, 8:32 p.m.
Message ID <1350246738-31699-17-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/191405/
State Accepted
Headers show

Comments

Colin King - Oct. 14, 2012, 8:32 p.m.
From: Colin Ian King <colin.king@canonical.com>

A missing comma in the bios_info[] was making fwts omit the
dumping of the product_serial information.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/bios/bios_info/bios_info.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Alex Hung - Oct. 15, 2012, 5:38 a.m.
On 10/15/2012 04:32 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> A missing comma in the bios_info[] was making fwts omit the
> dumping of the product_serial information.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/bios/bios_info/bios_info.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/bios/bios_info/bios_info.c b/src/bios/bios_info/bios_info.c
> index 748aad8..abe1a31 100644
> --- a/src/bios/bios_info/bios_info.c
> +++ b/src/bios/bios_info/bios_info.c
> @@ -43,7 +43,7 @@ static fwts_bios_info bios_info[] = {
>   	{ "chassis_version",	"Chassis Version" },
>   	{ "chassis_asset_tag",	"Chassic Asset Tag" },
>   	{ "product_name",	"Product Name" },
> -	{ "product_serial"	"Product Serial #" },
> +	{ "product_serial",	"Product Serial #" },
>   	{ "product_uuid",	"Product UUID " },
>   	{ "product_version",	"Product Version" },
>   	{ "sys_vendor",		"System Vendor" },
>

Acked-by: Alex Hung <alex.hung@canonical.com>
Keng-Yu Lin - Oct. 17, 2012, 7:52 a.m.
On Mon, Oct 15, 2012 at 4:32 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> A missing comma in the bios_info[] was making fwts omit the
> dumping of the product_serial information.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/bios/bios_info/bios_info.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/bios/bios_info/bios_info.c b/src/bios/bios_info/bios_info.c
> index 748aad8..abe1a31 100644
> --- a/src/bios/bios_info/bios_info.c
> +++ b/src/bios/bios_info/bios_info.c
> @@ -43,7 +43,7 @@ static fwts_bios_info bios_info[] = {
>         { "chassis_version",    "Chassis Version" },
>         { "chassis_asset_tag",  "Chassic Asset Tag" },
>         { "product_name",       "Product Name" },
> -       { "product_serial"      "Product Serial #" },
> +       { "product_serial",     "Product Serial #" },
>         { "product_uuid",       "Product UUID " },
>         { "product_version",    "Product Version" },
>         { "sys_vendor",         "System Vendor" },
> --
> 1.7.10.4
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>

Patch

diff --git a/src/bios/bios_info/bios_info.c b/src/bios/bios_info/bios_info.c
index 748aad8..abe1a31 100644
--- a/src/bios/bios_info/bios_info.c
+++ b/src/bios/bios_info/bios_info.c
@@ -43,7 +43,7 @@  static fwts_bios_info bios_info[] = {
 	{ "chassis_version",	"Chassis Version" },
 	{ "chassis_asset_tag",	"Chassic Asset Tag" },
 	{ "product_name",	"Product Name" },
-	{ "product_serial"	"Product Serial #" },
+	{ "product_serial",	"Product Serial #" },
 	{ "product_uuid",	"Product UUID " },
 	{ "product_version",	"Product Version" },
 	{ "sys_vendor",		"System Vendor" },