Patchwork [13/26] acpi: acpitables: use the correct type for failed

login
register
mail settings
Submitter Colin King
Date Oct. 14, 2012, 8:32 p.m.
Message ID <1350246738-31699-14-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/191402/
State Accepted
Headers show

Comments

Colin King - Oct. 14, 2012, 8:32 p.m.
From: Colin Ian King <colin.king@canonical.com>

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/acpi/acpitables/acpitables.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Alex Hung - Oct. 15, 2012, 3:58 a.m.
On 10/15/2012 04:32 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/acpi/acpitables/acpitables.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/acpi/acpitables/acpitables.c b/src/acpi/acpitables/acpitables.c
> index 1aa3f44..8cdcc31 100644
> --- a/src/acpi/acpitables/acpitables.c
> +++ b/src/acpi/acpitables/acpitables.c
> @@ -491,7 +491,7 @@ static int acpi_table_check_test1(fwts_framework *fw)
>   	int i;
>
>   	for (i=0; check_table[i].name != NULL; i++) {
> -		int failed = fw->minor_tests.failed;
> +		uint32_t failed = fw->minor_tests.failed;
>   		fwts_acpi_table_info *table;
>
>   		if (fwts_acpi_find_table(fw, check_table[i].name, 0, &table) != FWTS_OK) {
>

Acked-by: Alex Hung <alex.hung@canonical.com>
Keng-Yu Lin - Oct. 17, 2012, 7:45 a.m.
On Mon, Oct 15, 2012 at 4:32 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/acpi/acpitables/acpitables.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/acpi/acpitables/acpitables.c b/src/acpi/acpitables/acpitables.c
> index 1aa3f44..8cdcc31 100644
> --- a/src/acpi/acpitables/acpitables.c
> +++ b/src/acpi/acpitables/acpitables.c
> @@ -491,7 +491,7 @@ static int acpi_table_check_test1(fwts_framework *fw)
>         int i;
>
>         for (i=0; check_table[i].name != NULL; i++) {
> -               int failed = fw->minor_tests.failed;
> +               uint32_t failed = fw->minor_tests.failed;
>                 fwts_acpi_table_info *table;
>
>                 if (fwts_acpi_find_table(fw, check_table[i].name, 0, &table) != FWTS_OK) {
> --
> 1.7.10.4
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>

Patch

diff --git a/src/acpi/acpitables/acpitables.c b/src/acpi/acpitables/acpitables.c
index 1aa3f44..8cdcc31 100644
--- a/src/acpi/acpitables/acpitables.c
+++ b/src/acpi/acpitables/acpitables.c
@@ -491,7 +491,7 @@  static int acpi_table_check_test1(fwts_framework *fw)
 	int i;
 
 	for (i=0; check_table[i].name != NULL; i++) {
-		int failed = fw->minor_tests.failed;
+		uint32_t failed = fw->minor_tests.failed;
 		fwts_acpi_table_info *table;
 
 		if (fwts_acpi_find_table(fw, check_table[i].name, 0, &table) != FWTS_OK) {