Patchwork [5/7] hw/pl011: Use LOG_UNIMP and LOG_GUEST_ERROR

login
register
mail settings
Submitter Peter Maydell
Date Oct. 14, 2012, 1:11 p.m.
Message ID <1350220276-16349-6-git-send-email-peter.maydell@linaro.org>
Download mbox | patch
Permalink /patch/191351/
State New
Headers show

Comments

Peter Maydell - Oct. 14, 2012, 1:11 p.m.
Use the new LOG_UNIMP and LOG_GUEST_ERROR logging types rather
than hw_error().

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 hw/pl011.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

Patch

diff --git a/hw/pl011.c b/hw/pl011.c
index 3245702..743eea6 100644
--- a/hw/pl011.c
+++ b/hw/pl011.c
@@ -9,6 +9,7 @@ 
 
 #include "sysbus.h"
 #include "qemu-char.h"
+#include "qemu-log.h"
 
 typedef struct {
     SysBusDevice busdev;
@@ -107,7 +108,8 @@  static uint64_t pl011_read(void *opaque, target_phys_addr_t offset,
     case 18: /* UARTDMACR */
         return s->dmacr;
     default:
-        hw_error("pl011_read: Bad offset %x\n", (int)offset);
+        qemu_log_mask(LOG_GUEST_ERROR,
+                      "pl011_read: Bad offset %x\n", (int)offset);
         return 0;
     }
 }
@@ -178,11 +180,13 @@  static void pl011_write(void *opaque, target_phys_addr_t offset,
         break;
     case 18: /* UARTDMACR */
         s->dmacr = value;
-        if (value & 3)
-            hw_error("PL011: DMA not implemented\n");
+        if (value & 3) {
+            qemu_log_mask(LOG_UNIMP, "pl011: DMA not implemented\n");
+        }
         break;
     default:
-        hw_error("pl011_write: Bad offset %x\n", (int)offset);
+        qemu_log_mask(LOG_GUEST_ERROR,
+                      "pl011_write: Bad offset %x\n", (int)offset);
     }
 }