From patchwork Sun Oct 14 13:08:47 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [1/2] vnc: fix segfault due to failed handshake From: Tim Hardeck X-Patchwork-Id: 191349 Message-Id: <1350220128-10140-2-git-send-email-thardeck@suse.de> To: qemu-devel@nongnu.org Cc: Tim Hardeck Date: Sun, 14 Oct 2012 15:08:47 +0200 When the VNC server disconnects due to a failed handshake we don't have vs->bh allocated yet. Check for this case and don't delete it. Signed-off-by: Tim Hardeck Acked-by: Andreas Färber --- ui/vnc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ui/vnc.c b/ui/vnc.c index 01b2daf..656895a 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -1055,7 +1055,9 @@ static void vnc_disconnect_finish(VncState *vs) vnc_unlock_output(vs); qemu_mutex_destroy(&vs->output_mutex); - qemu_bh_delete(vs->bh); + if (vs->bh != NULL) { + qemu_bh_delete(vs->bh); + } buffer_free(&vs->jobs_buffer); for (i = 0; i < VNC_STAT_ROWS; ++i) {