Patchwork [1/9] powerpc: 83xx: use module_i2c_driver macro

login
register
mail settings
Submitter Devendra Naga
Date Oct. 13, 2012, 7:05 p.m.
Message ID <1350155142-1629-1-git-send-email-devendra.aaru@gmail.com>
Download mbox | patch
Permalink /patch/191332/
State Superseded
Delegated to: Kumar Gala
Headers show

Comments

Devendra Naga - Oct. 13, 2012, 7:05 p.m.
replace the module init and exit calls containing the
i2c_add_driver and i2c_del_driver with the module_i2c_driver
macro as it does the same things as the code that is removed

Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
---

 Not compile tested, because i dont have a ppc cross toolchain
 arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c |   13 +------------
 1 files changed, 1 insertions(+), 12 deletions(-)
Kim Phillips - Oct. 16, 2012, 6:06 p.m.
On Sat, 13 Oct 2012 15:05:42 -0400
Devendra Naga <devendra.aaru@gmail.com> wrote:

> replace the module init and exit calls containing the
> i2c_add_driver and i2c_del_driver with the module_i2c_driver
> macro as it does the same things as the code that is removed
> 
> Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
> ---
> 
>  Not compile tested,

Tested-by: Kim Phillips <kim.phillips@freescale.com>

> because i dont have a ppc cross toolchain

fyi, ppc and more cross compilers are available here:

http://kernel.org/pub/tools/crosstool/

Kim

Patch

diff --git a/arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c b/arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c
index ef6537b..d27477b 100644
--- a/arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c
+++ b/arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c
@@ -232,18 +232,7 @@  static struct i2c_driver mcu_driver = {
 	.id_table = mcu_ids,
 };
 
-static int __init mcu_init(void)
-{
-	return i2c_add_driver(&mcu_driver);
-}
-module_init(mcu_init);
-
-static void __exit mcu_exit(void)
-{
-	i2c_del_driver(&mcu_driver);
-}
-module_exit(mcu_exit);
-
+module_i2c_driver(mcu_driver);
 MODULE_DESCRIPTION("Power Management and GPIO expander driver for "
 		   "MPC8349E-mITX-compatible MCU");
 MODULE_AUTHOR("Anton Vorontsov <avorontsov@ru.mvista.com>");