Patchwork [U-Boot,7/7] config: Enable CBFS, ext4 for coreboot

login
register
mail settings
Submitter Simon Glass
Date Oct. 13, 2012, 12:26 a.m.
Message ID <1350087972-1581-7-git-send-email-sjg@chromium.org>
Download mbox | patch
Permalink /patch/191268/
State Accepted, archived
Delegated to: Tom Rini
Headers show

Comments

Simon Glass - Oct. 13, 2012, 12:26 a.m.
Enable Coreboot and EXT4 Filesystems on the coreboot board.

Signed-off-by: Simon Glass <sjg@chromium.org>
---
 include/configs/coreboot.h |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
Tom Rini - Oct. 22, 2012, 8:38 p.m.
On Fri, Oct 12, 2012 at 05:26:12PM -0700, Simon Glass wrote:

> Enable Coreboot and EXT4 Filesystems on the coreboot board.
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>

cmd_ext4.c: In function 'do_ext4_write':
cmd_ext4.c:110:3: error: format '%lu' expects type 'long unsigned int',
but argument 4 has type 'int'

Is what I see with my toolchain.
Simon Glass - Oct. 23, 2012, 5:36 a.m.
Hi Tom,

On Mon, Oct 22, 2012 at 1:38 PM, Tom Rini <trini@ti.com> wrote:
> On Fri, Oct 12, 2012 at 05:26:12PM -0700, Simon Glass wrote:
>
>> Enable Coreboot and EXT4 Filesystems on the coreboot board.
>>
>> Signed-off-by: Simon Glass <sjg@chromium.org>
>
> cmd_ext4.c: In function 'do_ext4_write':
> cmd_ext4.c:110:3: error: format '%lu' expects type 'long unsigned int',
> but argument 4 has type 'int'
>
> Is what I see with my toolchain.

Hmm I thought I fixed the ext4 x86 warnings with my previous patch,
but clearly not. I will take another look and perhaps come up with
another patch.

Regards,
Simon

>
> --
> Tom

Patch

diff --git a/include/configs/coreboot.h b/include/configs/coreboot.h
index 0e89242..3df085b 100644
--- a/include/configs/coreboot.h
+++ b/include/configs/coreboot.h
@@ -92,6 +92,9 @@ 
 #define CONFIG_MAC_PARTITION
 #define CONFIG_ISO_PARTITION		/* Experimental */
 
+#define CONFIG_CMD_CBFS
+#define CONFIG_CMD_EXT4
+#define CONFIG_CMD_EXT4_WRITE
 
 /*-----------------------------------------------------------------------
  * Video Configuration