Patchwork [U-Boot,1/7] ide: Add printf format string for CONFIG_SYS_64BIT_LBA option

login
register
mail settings
Submitter Simon Glass
Date Oct. 13, 2012, 12:26 a.m.
Message ID <1350087972-1581-1-git-send-email-sjg@chromium.org>
Download mbox | patch
Permalink /patch/191266/
State Accepted, archived
Delegated to: Tom Rini
Headers show

Comments

Simon Glass - Oct. 13, 2012, 12:26 a.m.
From: Gabe Black <gabeblack@chromium.org>

The size of an LBA type changes depending on this option. We need to
use a different printf() string in each case, so create a define for
this.

Signed-off-by: Gabe Black <gabeblack@chromium.org>
Signed-off-by: Simon Glass <sjg@chromium.org>
---
 include/ide.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Tom Rini - Oct. 22, 2012, 9:05 p.m.
On Fri, Oct 12, 2012 at 05:26:06PM -0700, Simon Glass wrote:

> From: Gabe Black <gabeblack@chromium.org>
> 
> The size of an LBA type changes depending on this option. We need to
> use a different printf() string in each case, so create a define for
> this.
> 
> Signed-off-by: Gabe Black <gabeblack@chromium.org>
> Signed-off-by: Simon Glass <sjg@chromium.org>

Except for part 5 of 7, this series is applied to u-boot/master, but
please address the problem I reported on part 7.

Patch

diff --git a/include/ide.h b/include/ide.h
index 385e909..18d63b2 100644
--- a/include/ide.h
+++ b/include/ide.h
@@ -42,8 +42,10 @@ 
 
 #ifdef CONFIG_SYS_64BIT_LBA
 typedef uint64_t lbaint_t;
+#define LBAF "%llx"
 #else
 typedef ulong lbaint_t;
+#define LBAF "%lx"
 #endif
 
 /*