Patchwork [U-Boot] tools/env: Fix build failure from missing header include

login
register
mail settings
Submitter Joe Hershberger
Date Oct. 12, 2012, 8:23 p.m.
Message ID <1350073417-8866-1-git-send-email-joe.hershberger@ni.com>
Download mbox | patch
Permalink /patch/191198/
State Accepted
Delegated to: Tom Rini
Headers show

Comments

Joe Hershberger - Oct. 12, 2012, 8:23 p.m.
This was introduced in:
8679d0ffdcc0beafea8e6942c0c67cf859afa18e -
	COMMON: Use __stringify() instead of MK_STR()

The header is now needed since common.h is not included in this tool.

Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
---
 tools/env/fw_env.c | 1 +
 1 file changed, 1 insertion(+)
Marek Vasut - Oct. 12, 2012, 10:20 p.m.
Dear Joe Hershberger,

> This was introduced in:
> 8679d0ffdcc0beafea8e6942c0c67cf859afa18e -
> 	COMMON: Use __stringify() instead of MK_STR()
> 
> The header is now needed since common.h is not included in this tool.

Good find. This is -next, right ?

> Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
> ---
>  tools/env/fw_env.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/env/fw_env.c b/tools/env/fw_env.c
> index 520ce3f..ab8c15d 100644
> --- a/tools/env/fw_env.c
> +++ b/tools/env/fw_env.c
> @@ -26,6 +26,7 @@
> 
>  #include <errno.h>
>  #include <fcntl.h>
> +#include <linux/stringify.h>
>  #include <stdio.h>
>  #include <stdlib.h>
>  #include <stddef.h>

Best regards,
Marek Vasut
Joe Hershberger - Oct. 13, 2012, 3:55 a.m.
Hi Marek,

On Fri, Oct 12, 2012 at 5:20 PM, Marek Vasut <marex@denx.de> wrote:
> Dear Joe Hershberger,
>
>> This was introduced in:
>> 8679d0ffdcc0beafea8e6942c0c67cf859afa18e -
>>       COMMON: Use __stringify() instead of MK_STR()
>>
>> The header is now needed since common.h is not included in this tool.
>
> Good find. This is -next, right ?

Correct... this is based on -next.

-Joe
Tom Rini - Oct. 15, 2012, 11:04 p.m.
On Fri, Oct 12, 2012 at 10:23:37AM -0000, Joe Hershberger wrote:

> This was introduced in:
> 8679d0ffdcc0beafea8e6942c0c67cf859afa18e -
> 	COMMON: Use __stringify() instead of MK_STR()
> 
> The header is now needed since common.h is not included in this tool.
> 
> Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>

Applied to u-boot/master, thanks!

Patch

diff --git a/tools/env/fw_env.c b/tools/env/fw_env.c
index 520ce3f..ab8c15d 100644
--- a/tools/env/fw_env.c
+++ b/tools/env/fw_env.c
@@ -26,6 +26,7 @@ 
 
 #include <errno.h>
 #include <fcntl.h>
+#include <linux/stringify.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <stddef.h>