Patchwork target-arm/neon_helper: Remove obsolete FIXME comment

login
register
mail settings
Submitter Peter Maydell
Date Oct. 12, 2012, 6:07 p.m.
Message ID <1350065243-13147-1-git-send-email-peter.maydell@linaro.org>
Download mbox | patch
Permalink /patch/191169/
State New
Headers show

Comments

Peter Maydell - Oct. 12, 2012, 6:07 p.m.
Commit 33ebc29 fixed the bugs in the implementation of VQRSHL,
but forgot to remove the FIXME comment...

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 target-arm/neon_helper.c |    1 -
 1 file changed, 1 deletion(-)
Stefan Hajnoczi - Oct. 19, 2012, 8:32 a.m.
On Fri, Oct 12, 2012 at 07:07:23PM +0100, Peter Maydell wrote:
> Commit 33ebc29 fixed the bugs in the implementation of VQRSHL,
> but forgot to remove the FIXME comment...
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  target-arm/neon_helper.c |    1 -
>  1 file changed, 1 deletion(-)

Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches

Stefan

Patch

diff --git a/target-arm/neon_helper.c b/target-arm/neon_helper.c
index 8bb5129..9aa920d 100644
--- a/target-arm/neon_helper.c
+++ b/target-arm/neon_helper.c
@@ -788,7 +788,6 @@  uint64_t HELPER(neon_qshlu_s64)(CPUARMState *env, uint64_t valop, uint64_t shift
     return helper_neon_qshl_u64(env, valop, shiftop);
 }
 
-/* FIXME: This is wrong.  */
 #define NEON_FN(dest, src1, src2) do { \
     int8_t tmp; \
     tmp = (int8_t)src2; \