From patchwork Fri Oct 12 15:15:06 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Herring X-Patchwork-Id: 191147 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 60C4E2C0089 for ; Sat, 13 Oct 2012 02:16:26 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422792Ab2JLPPu (ORCPT ); Fri, 12 Oct 2012 11:15:50 -0400 Received: from mail-oa0-f46.google.com ([209.85.219.46]:49130 "EHLO mail-oa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1945928Ab2JLPPl (ORCPT ); Fri, 12 Oct 2012 11:15:41 -0400 Received: by mail-oa0-f46.google.com with SMTP id h16so2970020oag.19 for ; Fri, 12 Oct 2012 08:15:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=x0Q2DCmoIwRpFTEHo7/Myw85/rHN2zquQO4G/3dY8ZY=; b=QWh9SFWLC4FzqQWf0jBsMOVqiVCKwcaleZX4FEDjx9JdipIZ1dgNaCXhqhfl4tBNjS vJhQZOL06kiNrsZS9kevIZxqAYl3ZnyuJR2SCqZooFJeWJ+43NeaOvIYvC0jvmz4AtuL yU9X3gZG/IwfibOrzfQbE3hPk69vBD861hUZx8bHX3Nzfb3GoN5yRK7aIEEICQfWo8PD wcH/T2JVAw5YuxgxLB8JC91HeaBc3W+UAONhAX3uDDWCwe/xexv2KW4dK3pG24DTiUT5 l2ClrWMhSvO5wTIyblq0AEI5SYrRbBd/gwjPCx3c6/WF2xX0MnvykpVTOOYF1grIk12w D0Lg== Received: by 10.182.172.74 with SMTP id ba10mr3734731obc.83.1350054940850; Fri, 12 Oct 2012 08:15:40 -0700 (PDT) Received: from rob-laptop.calxeda.com ([173.226.190.126]) by mx.google.com with ESMTPS id bd5sm7025992obb.5.2012.10.12.08.15.34 (version=SSLv3 cipher=OTHER); Fri, 12 Oct 2012 08:15:39 -0700 (PDT) From: Rob Herring To: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Cc: jonathan@jonmasters.org, eric.dumazet@gmail.com, Mark Langsdorf , Rob Herring Subject: [PATCH 4/6] net: calxedaxgmac: drop some unnecessary register writes Date: Fri, 12 Oct 2012 10:15:06 -0500 Message-Id: <1350054908-30646-5-git-send-email-robherring2@gmail.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1350054908-30646-1-git-send-email-robherring2@gmail.com> References: <1350054908-30646-1-git-send-email-robherring2@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Rob Herring The interrupts have already been cleared, so we don't need to clear them again. Also, we could miss interrupts if they are cleared, but we don't process the packet. Signed-off-by: Rob Herring --- drivers/net/ethernet/calxeda/xgmac.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/net/ethernet/calxeda/xgmac.c b/drivers/net/ethernet/calxeda/xgmac.c index 117839e..4a1a06a 100644 --- a/drivers/net/ethernet/calxeda/xgmac.c +++ b/drivers/net/ethernet/calxeda/xgmac.c @@ -846,9 +846,6 @@ static void xgmac_free_dma_desc_rings(struct xgmac_priv *priv) static void xgmac_tx_complete(struct xgmac_priv *priv) { int i; - void __iomem *ioaddr = priv->base; - - writel(DMA_STATUS_TU | DMA_STATUS_NIS, ioaddr + XGMAC_DMA_STATUS); while (dma_ring_cnt(priv->tx_head, priv->tx_tail, DMA_TX_RING_SZ)) { unsigned int entry = priv->tx_tail; @@ -1139,9 +1136,6 @@ static int xgmac_rx(struct xgmac_priv *priv, int limit) struct sk_buff *skb; int frame_len; - writel(DMA_STATUS_RI | DMA_STATUS_NIS, - priv->base + XGMAC_DMA_STATUS); - entry = priv->rx_tail; p = priv->dma_rx + entry; if (desc_get_owner(p))