Patchwork Adjust target for vect/pr48765.c

login
register
mail settings
Submitter Joe Seymour
Date Oct. 12, 2012, 3:05 p.m.
Message ID <507831D1.7010801@codesourcery.com>
Download mbox | patch
Permalink /patch/191138/
State New
Headers show

Comments

Joe Seymour - Oct. 12, 2012, 3:05 p.m.
I'm observing vect/pr48765.c fail for non 64-bit PowerPC targets:

> gcc/testsuite/gcc.dg/vect/pr48765.c:1:0: error: -m64 not supported in this
configuration

This patch restricts the test to 64-bit PowerPC targets. I don't have commit
access, so if this OK perhaps someone could commit it for me?

Thanks,

2012-10-12  Joe Seymour  <jseymour@codesourcery.com>

	* gcc.dg/vect/pr48765.c: Restrict to 64-bit PowerPC targets.
Janis Johnson - Oct. 12, 2012, 5:17 p.m.
On 10/12/2012 08:05 AM, Joe Seymour wrote:
> I'm observing vect/pr48765.c fail for non 64-bit PowerPC targets:
> 
>> gcc/testsuite/gcc.dg/vect/pr48765.c:1:0: error: -m64 not supported in this
> configuration
> 
> This patch restricts the test to 64-bit PowerPC targets. I don't have commit
> access, so if this OK perhaps someone could commit it for me?
> 
> Thanks,
> 
> 2012-10-12  Joe Seymour  <jseymour@codesourcery.com>
> 
> 	* gcc.dg/vect/pr48765.c: Restrict to 64-bit PowerPC targets.
> 
> Index: gcc/testsuite/gcc.dg/vect/pr48765.c
> ===================================================================
> --- gcc/testsuite/gcc.dg/vect/pr48765.c (revision 192402)
> +++ gcc/testsuite/gcc.dg/vect/pr48765.c (working copy)
> @@ -1,4 +1,4 @@
> -/* { dg-do compile { target powerpc*-*-* } } */
> +/* { dg-do compile { target powerpc64 } } */
>  /* { dg-options "-m64 -O3 -mcpu=power6" } */
> 
>  enum reg_class
> 

No, the test should not add -m64, and -mcpu=power6 might conflict
with multilib options.  I proposed a different fix for this test in
<http://gcc.gnu.org/ml/gcc-patches/2012-09/msg01320.html> and then
didn't follow up on it.

I've copied Ira who added the test to see what she thinks of my
proposed change, and David as the Power maintainer.

Janis
Peter Bergner - Oct. 12, 2012, 7:14 p.m.
On Fri, 2012-10-12 at 10:17 -0700, Janis Johnson wrote:
> No, the test should not add -m64, and -mcpu=power6 might conflict
> with multilib options.  I proposed a different fix for this test in
> <http://gcc.gnu.org/ml/gcc-patches/2012-09/msg01320.html> and then
> didn't follow up on it.
> 
> I've copied Ira who added the test to see what she thinks of my
> proposed change, and David as the Power maintainer.

Just my $0.02 worth Janis, but I liked your patch, since it attempts
to test the test case with the options that exposed the bug in the
first place (ie, -mcpu=power6), but plays nicely with people who want
to explicitly set -mcpu= to something else.  Your other suggestion
would mean the only time the test case is tested with the options that
made it fail originally would be when someone does a --with-cpu=power6
build and that isn't something we do now that power7 has been released
for a while now.

Peter
David Edelsohn - Oct. 12, 2012, 7:42 p.m.
On Fri, Oct 12, 2012 at 1:17 PM, Janis Johnson <janis_johnson@mentor.com> wrote:
> On 10/12/2012 08:05 AM, Joe Seymour wrote:
>> I'm observing vect/pr48765.c fail for non 64-bit PowerPC targets:
>>
>>> gcc/testsuite/gcc.dg/vect/pr48765.c:1:0: error: -m64 not supported in this
>> configuration
>>
>> This patch restricts the test to 64-bit PowerPC targets. I don't have commit
>> access, so if this OK perhaps someone could commit it for me?
>>
>> Thanks,
>>
>> 2012-10-12  Joe Seymour  <jseymour@codesourcery.com>
>>
>>       * gcc.dg/vect/pr48765.c: Restrict to 64-bit PowerPC targets.
>>
>> Index: gcc/testsuite/gcc.dg/vect/pr48765.c
>> ===================================================================
>> --- gcc/testsuite/gcc.dg/vect/pr48765.c (revision 192402)
>> +++ gcc/testsuite/gcc.dg/vect/pr48765.c (working copy)
>> @@ -1,4 +1,4 @@
>> -/* { dg-do compile { target powerpc*-*-* } } */
>> +/* { dg-do compile { target powerpc64 } } */
>>  /* { dg-options "-m64 -O3 -mcpu=power6" } */
>>
>>  enum reg_class
>>
>
> No, the test should not add -m64, and -mcpu=power6 might conflict
> with multilib options.  I proposed a different fix for this test in
> <http://gcc.gnu.org/ml/gcc-patches/2012-09/msg01320.html> and then
> didn't follow up on it.
>
> I've copied Ira who added the test to see what she thinks of my
> proposed change, and David as the Power maintainer.

Janis,

Your patch seems reasonable to me.

Thanks, David

Patch

Index: gcc/testsuite/gcc.dg/vect/pr48765.c
===================================================================
--- gcc/testsuite/gcc.dg/vect/pr48765.c (revision 192402)
+++ gcc/testsuite/gcc.dg/vect/pr48765.c (working copy)
@@ -1,4 +1,4 @@ 
-/* { dg-do compile { target powerpc*-*-* } } */
+/* { dg-do compile { target powerpc64 } } */
 /* { dg-options "-m64 -O3 -mcpu=power6" } */

 enum reg_class