Patchwork [PULL,0/7] serial device hotplug patch series.

login
register
mail settings
Submitter Gerd Hoffmann
Date Oct. 12, 2012, 9:25 a.m.
Message ID <1350033962-16665-1-git-send-email-kraxel@redhat.com>
Download mbox
Permalink /patch/191081/
State New
Headers show

Pull-request

git://git.kraxel.org/qemu serial.1

Comments

Gerd Hoffmann - Oct. 12, 2012, 9:25 a.m.
Hi,

This patch series tackles serial device hotplug.

The first four patches have been on the list before, they implement
pci-serial devices featuring a hot-pluggable 16550 uart and got some
minor tweaks only.

The next two patches update the usb-serial device.  It will only show up
in the guest when the chardev is open.  You'll see the difference with
socket chardevs:  If you open the chardev (by connecting to the socket)
the device will show up in the guest, on close (disconnect) it will
disappear.

Final patch adds chardev hotplug to the mix, which makes the other
patches alot more useful.  It is the missing bit needed to really
hotplug serial devices:

   (qemu) chardev_add pciserial file /root/hotchardev.log
   (qemu) device_add pci-serial,chardev=pciserial,id=pciserial

And the reverse:

   (qemu) device_del pciserial
   (qemu) chardev_del pciserial

please review & pull,
  Gerd

The following changes since commit b4ae3cfa57b8c1bdbbd7b7d420971e9171203ade:

  ssi: Add slave autoconnect helper (2012-10-10 11:13:32 +1000)

are available in the git repository at:
  git://git.kraxel.org/qemu serial.1

Gerd Hoffmann (7):
      serial: split serial.c
      serial: add pci variant
      serial: add windows inf file for the pci card to docs
      serial: add 2x + 4x pci variant
      usb-serial: don't magically zap chardev on umplug
      usb-serial: only expose device in guest when the chardev is open
      chardev: add hotplug support.

 default-configs/pci.mak  |    2 +
 docs/qemupciserial.inf   |  109 ++++++++++++++++++
 hmp-commands.hx          |   49 ++++++++
 hmp.c                    |   39 +++++++
 hmp.h                    |    2 +
 hw/Makefile.objs         |    3 +-
 hw/alpha_dp264.c         |    1 +
 hw/kzm.c                 |    2 +-
 hw/mips_fulong2e.c       |    1 +
 hw/mips_jazz.c           |    1 +
 hw/mips_malta.c          |    1 +
 hw/mips_mipssim.c        |    2 +-
 hw/mips_r4k.c            |    1 +
 hw/musicpal.c            |    2 +-
 hw/omap_uart.c           |    3 +-
 hw/openrisc_sim.c        |    3 +-
 hw/pc.c                  |    1 +
 hw/pc.h                  |   27 -----
 hw/pci_ids.h             |    1 +
 hw/petalogix_ml605_mmu.c |    2 +-
 hw/ppc/e500.c            |    2 +-
 hw/ppc405_uc.c           |    2 +-
 hw/ppc440_bamboo.c       |    2 +-
 hw/ppc_prep.c            |    1 +
 hw/pxa2xx.c              |    2 +-
 hw/serial-isa.c          |  130 ++++++++++++++++++++++
 hw/serial-pci.c          |  272 ++++++++++++++++++++++++++++++++++++++++++++++
 hw/serial.c              |  149 ++-----------------------
 hw/serial.h              |   74 +++++++++++++
 hw/sm501.c               |    2 +-
 hw/sun4u.c               |    1 +
 hw/usb/dev-serial.c      |   21 +++-
 hw/virtex_ml507.c        |    2 +-
 hw/xtensa_lx60.c         |    3 +-
 qapi-schema.json         |   46 ++++++++
 qemu-char.c              |   74 +++++++++++++
 qmp-commands.hx          |   61 ++++++++++
 37 files changed, 913 insertions(+), 183 deletions(-)
 create mode 100644 docs/qemupciserial.inf
 create mode 100644 hw/serial-isa.c
 create mode 100644 hw/serial-pci.c
 create mode 100644 hw/serial.h
Paolo Bonzini - Oct. 12, 2012, 9:42 a.m.
Il 12/10/2012 11:25, Gerd Hoffmann ha scritto:
> Final patch adds chardev hotplug to the mix, which makes the other
> patches alot more useful.  It is the missing bit needed to really
> hotplug serial devices:
> 
>    (qemu) chardev_add pciserial file /root/hotchardev.log
>    (qemu) device_add pci-serial,chardev=pciserial,id=pciserial
> 
> And the reverse:
> 
>    (qemu) device_del pciserial
>    (qemu) chardev_del pciserial
> 
> please review & pull,

I think the last patch is not ready, please wait for Luiz's review too.

>   Gerd
> 
> The following changes since commit b4ae3cfa57b8c1bdbbd7b7d420971e9171203ade:
> 
>   ssi: Add slave autoconnect helper (2012-10-10 11:13:32 +1000)
> 
> are available in the git repository at:
>   git://git.kraxel.org/qemu serial.1
> 
> Gerd Hoffmann (7):
>       serial: split serial.c
>       serial: add pci variant
>       serial: add windows inf file for the pci card to docs
>       serial: add 2x + 4x pci variant
>       usb-serial: don't magically zap chardev on umplug
>       usb-serial: only expose device in guest when the chardev is open
>       chardev: add hotplug support.