Patchwork vti: fix sparse bit endian warnings

login
register
mail settings
Submitter stephen hemminger
Date Oct. 11, 2012, 10:51 p.m.
Message ID <20121011155128.64774827@nehalam.linuxnetplumber.net>
Download mbox | patch
Permalink /patch/191016/
State Accepted
Delegated to: David Miller
Headers show

Comments

stephen hemminger - Oct. 11, 2012, 10:51 p.m.
Use be32_to_cpu instead of htonl to keep sparse happy.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.org>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Oct. 12, 2012, 5:57 p.m.
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Thu, 11 Oct 2012 15:51:28 -0700

> Use be32_to_cpu instead of htonl to keep sparse happy.
> 
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.org>

Using ntohl() would have been just as appropriate a fix, but
whatever, applied.  Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

--- a/net/ipv4/ip_vti.c	2012-10-10 11:54:57.165566432 -0700
+++ b/net/ipv4/ip_vti.c	2012-10-11 11:06:35.696333265 -0700
@@ -374,7 +374,7 @@  static netdev_tx_t vti_tunnel_xmit(struc
 
 	memset(&fl4, 0, sizeof(fl4));
 	flowi4_init_output(&fl4, tunnel->parms.link,
-			   htonl(tunnel->parms.i_key), RT_TOS(tos),
+			   be32_to_cpu(tunnel->parms.i_key), RT_TOS(tos),
 			   RT_SCOPE_UNIVERSE,
 			   IPPROTO_IPIP, 0,
 			   dst, tiph->saddr, 0, 0);
@@ -441,7 +441,7 @@  static int vti_tunnel_bind_dev(struct ne
 		struct flowi4 fl4;
 		memset(&fl4, 0, sizeof(fl4));
 		flowi4_init_output(&fl4, tunnel->parms.link,
-				   htonl(tunnel->parms.i_key),
+				   be32_to_cpu(tunnel->parms.i_key),
 				   RT_TOS(iph->tos), RT_SCOPE_UNIVERSE,
 				   IPPROTO_IPIP, 0,
 				   iph->daddr, iph->saddr, 0, 0);