Patchwork New package liblog4c-localtime

login
register
mail settings
Submitter Alexander Varnin
Date Oct. 11, 2012, 9:34 a.m.
Message ID <1349948066-12255-1-git-send-email-fenixk19@mail.ru>
Download mbox | patch
Permalink /patch/190842/
State Accepted
Headers show

Comments

Alexander Varnin - Oct. 11, 2012, 9:34 a.m.
Signed-off-by: Alexander Varnin <fenixk19@mail.ru>
---
 package/Config.in                                |    1 +
 package/liblog4c-localtime/Config.in             |   10 ++++++++++
 package/liblog4c-localtime/liblog4c-localtime.mk |   18 ++++++++++++++++++
 3 files changed, 29 insertions(+), 0 deletions(-)
 create mode 100644 package/liblog4c-localtime/Config.in
 create mode 100644 package/liblog4c-localtime/liblog4c-localtime.mk
Peter Korsgaard - Oct. 21, 2012, 7:10 p.m.
>>>>> "Alexander" == Alexander Varnin <fenixk19@mail.ru> writes:

 Alexander> Signed-off-by: Alexander Varnin <fenixk19@mail.ru>

Thanks, committed with minor fixes (see below).

 Alexander> +++ b/package/liblog4c-localtime/Config.in
 Alexander> @@ -0,0 +1,10 @@
 Alexander> +config BR2_PACKAGE_LIBLOG4C_LOCALTIME
 Alexander> +	bool "liblog4c-localtime"

You forgot to select BR2_PACKAGE_EXPAT.

 Alexander> +	help
 Alexander> +	  Log4c is a library of C for flexible logging to files, syslog 

Please no trailing spaces.

 Alexander> +	  and other destinations.
 Alexander> +	  This version is with localtime patch, to make lib show times in
 Alexander> +	  local timezone.
 Alexander> +
 Alexander> +	  https://github.com/rcmadruga/log4c-localtime
 Alexander> +          http://log4c.sourceforge.net/

This should be indented with <tab><space><space> like the rest.

 Alexander> diff --git a/package/liblog4c-localtime/liblog4c-localtime.mk b/package/liblog4c-localtime/liblog4c-localtime.mk
 Alexander> new file mode 100644
 Alexander> index 0000000..0aedec8
 Alexander> --- /dev/null
 Alexander> +++ b/package/liblog4c-localtime/liblog4c-localtime.mk
 Alexander> @@ -0,0 +1,18 @@
 Alexander> + #############################################################
 Alexander> + #
 Alexander> + # liblog4c
 Alexander> + #
 Alexander> + #############################################################
 Alexander> + LIBLOG4C_LOCALTIME_VERSION = 1.0
 Alexander> + LIBLOG4C_LOCALTIME_SITE    = https://github.com/rcmadruga/log4c-localtime/tarball/v$(LIBLOG4C_LOCALTIME_VERSION) 

Please no trailing spaces.

 Alexander> + LIBLOG4C_LOCALTIME_INSTALL_STAGING = YES
 Alexander> + LIBLOG4C_LOCALTIME_CONF_OPT = --disable-expattest
 Alexander> + LIBLOG4C_LOCALTIME_DEPENDENCIES = expat
 Alexander> +
 Alexander> + define LIBLOG4C_LOCALTIME_HOOK
 Alexander> +   chmod +x $(@D)/configure
 Alexander> + endef
 Alexander> +
 Alexander> + LIBLOG4C_LOCALTIME_PRE_CONFIGURE_HOOKS += LIBLOG4C_LOCALTIME_HOOK

Please don't indent this. I renamed this hook to
LIBLOG4C_LOCALTIME_FIX_CONFIGURE_PERMS to make it clear what it does.

Patch

diff --git a/package/Config.in b/package/Config.in
index 8a7c9c4..25752e5 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -387,6 +387,7 @@  source "package/lttng-libust/Config.in"
 source "package/orc/Config.in"
 source "package/poco/Config.in"
 source "package/startup-notification/Config.in"
+source "package/liblog4c-localtime/Config.in"
 endmenu
 
 menu "Text and terminal handling"
diff --git a/package/liblog4c-localtime/Config.in b/package/liblog4c-localtime/Config.in
new file mode 100644
index 0000000..5e9b863
--- /dev/null
+++ b/package/liblog4c-localtime/Config.in
@@ -0,0 +1,10 @@ 
+config BR2_PACKAGE_LIBLOG4C_LOCALTIME
+	bool "liblog4c-localtime"
+	help
+	  Log4c is a library of C for flexible logging to files, syslog 
+	  and other destinations.
+	  This version is with localtime patch, to make lib show times in
+	  local timezone.
+
+	  https://github.com/rcmadruga/log4c-localtime
+          http://log4c.sourceforge.net/
diff --git a/package/liblog4c-localtime/liblog4c-localtime.mk b/package/liblog4c-localtime/liblog4c-localtime.mk
new file mode 100644
index 0000000..0aedec8
--- /dev/null
+++ b/package/liblog4c-localtime/liblog4c-localtime.mk
@@ -0,0 +1,18 @@ 
+ #############################################################
+ #
+ # liblog4c
+ #
+ #############################################################
+ LIBLOG4C_LOCALTIME_VERSION = 1.0
+ LIBLOG4C_LOCALTIME_SITE    = https://github.com/rcmadruga/log4c-localtime/tarball/v$(LIBLOG4C_LOCALTIME_VERSION) 
+ LIBLOG4C_LOCALTIME_INSTALL_STAGING = YES
+ LIBLOG4C_LOCALTIME_CONF_OPT = --disable-expattest
+ LIBLOG4C_LOCALTIME_DEPENDENCIES = expat
+
+ define LIBLOG4C_LOCALTIME_HOOK
+   chmod +x $(@D)/configure
+ endef
+
+ LIBLOG4C_LOCALTIME_PRE_CONFIGURE_HOOKS += LIBLOG4C_LOCALTIME_HOOK
+
+ $(eval $(autotools-package))