From patchwork Wed Oct 10 16:02:40 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 190722 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 5B3732C0083 for ; Thu, 11 Oct 2012 04:19:35 +1100 (EST) Received: from localhost ([::1]:60733 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLylj-0007vh-07 for incoming@patchwork.ozlabs.org; Wed, 10 Oct 2012 12:04:23 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52858) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLyka-0005lb-Ij for qemu-devel@nongnu.org; Wed, 10 Oct 2012 12:03:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TLykP-0007eY-8w for qemu-devel@nongnu.org; Wed, 10 Oct 2012 12:03:12 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:38945) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLykO-0007dw-PI for qemu-devel@nongnu.org; Wed, 10 Oct 2012 12:03:01 -0400 Received: by mail-pa0-f45.google.com with SMTP id fb10so744870pad.4 for ; Wed, 10 Oct 2012 09:03:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references; bh=PDalpsLJTuLUrISDxZZ+KdNlvJgrG8YirXoywnyIBcA=; b=QDZ7VjYx9mr+WMjoM9zsv/5L9bNPi+8NG/uWQNJwjGSuQ+E8GGDLb18ZVRGIU9riiZ mqYZQsbzeGpG07F6Slcl36Q4SoBEa5h9K2/jmPmGTBOZ755DRhU22a4reYo/a6mYlHfU ZxxVS1ZfEcqIy1i9MkFBrTonaz1lqDLX+3g9SH1BMvZ1LHnOV42b9/c5mOZLqkMiYo9P GHbHJylCUFSxhGOrEMvXFhjRGn2geBk4c2HU7bPnvBx3B9LL9MMRz+Pl0Ik+wCrQTs5I TBf5Nn9ahp2xctq8iYVyoeJsHeY/ftT2a7MW7rJK5/BAp+0jc5wdLZmtRHyaR9yanhjl 8+2g== Received: by 10.68.204.162 with SMTP id kz2mr27339020pbc.76.1349884980375; Wed, 10 Oct 2012 09:03:00 -0700 (PDT) Received: from anchor.twiddle.home.com (50-194-63-110-static.hfc.comcastbusiness.net. [50.194.63.110]) by mx.google.com with ESMTPS id sj5sm1216694pbc.30.2012.10.10.09.02.59 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 10 Oct 2012 09:02:59 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Wed, 10 Oct 2012 09:02:40 -0700 Message-Id: <1349884967-4608-7-git-send-email-rth@twiddle.net> X-Mailer: git-send-email 1.7.11.4 In-Reply-To: <1349884967-4608-1-git-send-email-rth@twiddle.net> References: <1349884967-4608-1-git-send-email-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.220.45 Cc: Blue Swirl Subject: [Qemu-devel] [PATCH 06/13] tcg-sparc: Fix setcond X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org The set of comparisons that can immediately use the carry are LTU/GEU, not LTU/LEU. Don't swap operands when we need a temp register; the register may already be in use from setcond2. Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c | 33 +++++++++++++++++++-------------- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/tcg/sparc/tcg-target.c b/tcg/sparc/tcg-target.c index 3144044..31e8204 100644 --- a/tcg/sparc/tcg-target.c +++ b/tcg/sparc/tcg-target.c @@ -617,32 +617,37 @@ static void tcg_out_brcond2_i32(TCGContext *s, TCGCond cond, static void tcg_out_setcond_i32(TCGContext *s, TCGCond cond, TCGArg ret, TCGArg c1, TCGArg c2, int c2const) { - TCGArg t; - /* For 32-bit comparisons, we can play games with ADDX/SUBX. */ switch (cond) { + case TCG_COND_LTU: + case TCG_COND_GEU: + /* The result of the comparison is in the carry bit. */ + break; + case TCG_COND_EQ: case TCG_COND_NE: + /* For equality, we can transform to inequality vs zero. */ if (c2 != 0) { tcg_out_arithc(s, ret, c1, c2, c2const, ARITH_XOR); } c1 = TCG_REG_G0, c2 = ret, c2const = 0; - cond = (cond == TCG_COND_EQ ? TCG_COND_LEU : TCG_COND_LTU); + cond = (cond == TCG_COND_EQ ? TCG_COND_GEU : TCG_COND_LTU); break; case TCG_COND_GTU: - case TCG_COND_GEU: - if (c2const && c2 != 0) { - tcg_out_movi_imm13(s, TCG_REG_T1, c2); - c2 = TCG_REG_T1; - } - t = c1, c1 = c2, c2 = t, c2const = 0; - cond = tcg_swap_cond(cond); - break; - - case TCG_COND_LTU: case TCG_COND_LEU: - break; + /* If we don't need to load a constant into a register, we can + swap the operands on GTU/LEU. There's no benefit to loading + the constant into a temporary register. */ + if (!c2const || c2 == 0) { + TCGArg t = c1; + c1 = c2; + c2 = t; + c2const = 0; + cond = tcg_swap_cond(cond); + break; + } + /* FALLTHRU */ default: tcg_out_cmp(s, c1, c2, c2const);