From patchwork Wed Oct 10 17:16:28 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: GCC 4.7 : PR 54861 - libstdc++ header file typo Date: Wed, 10 Oct 2012 07:16:28 -0000 From: Andrew MacLeod X-Patchwork-Id: 190720 Message-Id: <5075AD6C.8070405@redhat.com> To: gcc-patches This bootstraps and causes no new regressions on the 4.7 branch. Is it OK to check this into the 4.7 branch right now? Thanks Andrew -------- Original Message -------- Subject: PR 54861 - libstdc++ header file typo Date: Tue, 09 Oct 2012 14:40:46 -0400 From: Andrew MacLeod To: gcc-patches There is a typo in the header files for libstdc++ where the atomic_signal_fence() method is actually calling __atomic_thread_fence() instead of __atomic_signal_fence(). This results in extra barriers in the executable that don't need to be there. fixed as trivial and checked into mainline. Is it OK to check this into the 4.7 branch once I've verified it there as well? ie, it's not frozen or anything right now is it? Thanks Andrew 2012-10-09 Andrew MacLeod PR libstdc++/54861 * include/bits/atomic_base.h (atomic_signal_fence): Call __atomic_signal_fence instead of __atomic_thread_fence. Index: include/bits/atomic_base.h =================================================================== *** include/bits/atomic_base.h (revision 192254) --- include/bits/atomic_base.h (working copy) *************** _GLIBCXX_BEGIN_NAMESPACE_VERSION *** 74,80 **** inline void atomic_signal_fence(memory_order __m) noexcept ! { __atomic_thread_fence(__m); } /// kill_dependency template --- 74,80 ---- inline void atomic_signal_fence(memory_order __m) noexcept ! { __atomic_signal_fence(__m); } /// kill_dependency template