Patchwork GCC 4.7 : PR 54861 - libstdc++ header file typo

login
register
mail settings
Submitter Andrew MacLeod
Date Oct. 10, 2012, 5:16 p.m.
Message ID <5075AD6C.8070405@redhat.com>
Download mbox | patch
Permalink /patch/190720/
State New
Headers show

Comments

Andrew MacLeod - Oct. 10, 2012, 5:16 p.m.
This bootstraps and causes no new regressions on the 4.7 branch.    Is 
it OK to check this into the 4.7 branch right now?

Thanks
Andrew



-------- Original Message --------
Subject: 	PR 54861 - libstdc++ header file typo
Date: 	Tue, 09 Oct 2012 14:40:46 -0400
From: 	Andrew MacLeod <amacleod@redhat.com>
To: 	gcc-patches <gcc-patches@gcc.gnu.org>



There is a typo in the header files for libstdc++ where the
atomic_signal_fence() method is actually calling __atomic_thread_fence()
instead of __atomic_signal_fence(). This results in extra barriers in
the executable that don't need to be there.

fixed as trivial and checked into mainline.  Is it OK to check this into
the 4.7 branch once I've verified it there as well?  ie, it's not frozen
or anything right now is it?

Thanks
Andrew
Paolo Carlini - Oct. 10, 2012, 7:09 p.m.
On 10/10/2012 07:16 PM, Andrew MacLeod wrote:
>
> This bootstraps and causes no new regressions on the 4.7 branch.    Is 
> it OK to check this into the 4.7 branch right now?
Yes, thanks.

Paolo.

Patch


2012-10-09  Andrew MacLeod  <amacleod@redhat.com>

	PR libstdc++/54861
	* include/bits/atomic_base.h (atomic_signal_fence): Call
	__atomic_signal_fence instead of __atomic_thread_fence.

Index: include/bits/atomic_base.h
===================================================================
*** include/bits/atomic_base.h	(revision 192254)
--- include/bits/atomic_base.h	(working copy)
*************** _GLIBCXX_BEGIN_NAMESPACE_VERSION
*** 74,80 ****
  
    inline void
    atomic_signal_fence(memory_order __m) noexcept
!   { __atomic_thread_fence(__m); }
  
    /// kill_dependency
    template<typename _Tp>
--- 74,80 ----
  
    inline void
    atomic_signal_fence(memory_order __m) noexcept
!   { __atomic_signal_fence(__m); }
  
    /// kill_dependency
    template<typename _Tp>