| Submitter | Paolo Bonzini |
|---|---|
| Date | Oct. 10, 2012, 4:19 p.m. |
| Message ID | <1349885969-25866-1-git-send-email-pbonzini@redhat.com> |
| Download | mbox | patch |
| Permalink | /patch/190712/ |
| State | New |
| Headers | show |
Comments
Am 10.10.2012 18:19, schrieb Paolo Bonzini: > Fixes the following error with glibc 2.16 on Fedora 18: > > virtfs-proxy-helper.c: In function ‘setfsugid’: > virtfs-proxy-helper.c:293:13: error: ignoring return value of ‘setfsgid’, declared with attribute warn_unused_result [-Werror=unused-result] > virtfs-proxy-helper.c:294:13: error: ignoring return value of ‘setfsuid’, declared with attribute warn_unused_result [-Werror=unused-result] > cc1: all warnings being treated as errors > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > --- > fsdev/virtfs-proxy-helper.c | 8 ++++++-- > 1 file modificato, 6 inserzioni(+), 2 rimozioni(-) > > diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c > index f9a8270..9060743 100644 > --- a/fsdev/virtfs-proxy-helper.c > +++ b/fsdev/virtfs-proxy-helper.c > @@ -290,8 +290,12 @@ static int setfsugid(int uid, int gid) > CAP_DAC_OVERRIDE, > }; > > - setfsgid(gid); > - setfsuid(uid); > + if (setfsgid(gid) < 0) { > + return -1; > + } > + if (setfsuid(uid) < 0) { > + return -1; > + } > > if (uid != 0 || gid != 0) { > return do_cap_set(cap_list, ARRAY_SIZE(cap_list), 0); You are too fast for me :-) Patch v3 is needed, see my other mail. Stefan
Patch
diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c index f9a8270..9060743 100644 --- a/fsdev/virtfs-proxy-helper.c +++ b/fsdev/virtfs-proxy-helper.c @@ -290,8 +290,12 @@ static int setfsugid(int uid, int gid) CAP_DAC_OVERRIDE, }; - setfsgid(gid); - setfsuid(uid); + if (setfsgid(gid) < 0) { + return -1; + } + if (setfsuid(uid) < 0) { + return -1; + } if (uid != 0 || gid != 0) { return do_cap_set(cap_list, ARRAY_SIZE(cap_list), 0);
Fixes the following error with glibc 2.16 on Fedora 18: virtfs-proxy-helper.c: In function ‘setfsugid’: virtfs-proxy-helper.c:293:13: error: ignoring return value of ‘setfsgid’, declared with attribute warn_unused_result [-Werror=unused-result] virtfs-proxy-helper.c:294:13: error: ignoring return value of ‘setfsuid’, declared with attribute warn_unused_result [-Werror=unused-result] cc1: all warnings being treated as errors Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> --- fsdev/virtfs-proxy-helper.c | 8 ++++++-- 1 file modificato, 6 inserzioni(+), 2 rimozioni(-)